Date: Wed, 19 Nov 2014 19:22:47 +0300 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r274661 - in head/sys: conf geom/part modules/geom/geom_part/geom_part_bsd Message-ID: <546CC3D7.9010500@FreeBSD.org> In-Reply-To: <B523D699-9766-4806-9499-68FD9FF84437@bsdimp.com> References: <201411181706.sAIH6eS9051888@svn.freebsd.org> <546CC245.3070700@FreeBSD.org> <B523D699-9766-4806-9499-68FD9FF84437@bsdimp.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 19.11.2014 19:20, Warner Losh wrote: >> Probably you need to use basetable->gpt_entries here instead of >> MAXPARTITIONS. > > I’m having trouble connecting the dots between GPT and BSDlabels. Why > would this field be relevant? Is it just poorly named? MAXPARTITIONS > is the number of partitions we support. It’s always a constant. While > there are other BSD label formats that have differing numbers, I > don’t think gpart supports those. But as always, I’m always on the > lookout for code improvements. BSD label supports up to 20 partitons. You can specify different number with `gpart create -n 20 -s bsd`. For such labels your code will return EINVAL. -- WBR, Andrey V. Elsukov [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJUbMPdAAoJEAHF6gQQyKF6uhgH/13V/kRtZ84NhK0+F/lL+WAj FlxmDOEtJuRwLLeOgM1NmtJ/UPl4F/8CdGGqQj/G2R9oUF/z/hNV0AqAkKlK3O+c Mt9/ITWSYbompBS1KgE51dQDGIqKmFCVDsI2I0GoxeGQvkcHHAChHfW1Fg9DG5pg EgXlh44EPuzZ65R6HdpfB2TyK37JKQSfjMwJqRNyzYxULLzcyvelr2v49SHSbI8q mqUfjHwInHueLpj5vdQin7wJR+xFbkqanKxdebUYx85aZ5m+qAJQR4cOTQvYvcxQ SwzGJ4krV3CLbwRWv16vyiS7rcA3oJSLHCBjlQCxlV+OXayXWxzJaKiq1G4Fr9o= =fsM9 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?546CC3D7.9010500>