Date: Tue, 20 Mar 2012 11:38:28 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-eclipse@FreeBSD.org, freebsd-java@FreeBSD.org Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj Message-ID: <20120320183828.GB13507@dormouse.experts-exchange.com> In-Reply-To: <201203201230.06968.jkim@FreeBSD.org> References: <20120318180225.GA51618@dormouse.experts-exchange.com> <201203191945.50219.jkim@FreeBSD.org> <20120319235959.GL46825@dormouse.experts-exchange.com> <201203201230.06968.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 20, 2012 at 12:29:57PM -0400, Jung-uk Kim thus spake:
>> I am unable to validate this with the jar that is built. Are you
>> able to get it to work?
>
>No, current port builds unusable ecj.jar. :-(
I am able to compile with it with no issue. What issues are you seeing?
>
>> >While you are at it, please add these:
>> >
>> >USE_ZIP= yes
>>
>> Why? It isn't a zip file, and why is this dependency required?
>
>A JAR file is essentially a ZIP file with additional meta-data, just
>like a FreeBSD package is a tarball with meta-data.
>
>% file /usr/local/openjdk6/jre/lib/rt.jar
>/usr/local/openjdk6/jre/lib/rt.jar: Zip archive data, at least v1.0 to
>extract
>
>If you are really concerned about the additiaonal build dependency,
>you may use jar but (bsd)tar is the worst choice.
Tar is completely valid for uncompressing zip archives.
>
>> >NO_WRKSUBDIR= yes
>>
>> Can't see why this would be an issue to put in.
>>
>> >and remove these:
>> >
>> >BUILD_WRKSRC= ${WRKDIR}
>>
>> Why? Otherwise, I need to put:
>> WRKSRC= ${WRKDIR}
>
>That's because it is easier to read/maintain for maintainer(s),
>"FOO=yes" is easier to parse with scripts, it is the "official" ports
>way to handle this case, etc, etc...
Scripts can still parse and find both WRKDIR and WRKSRC in this port
regardless of the option I use. If BUILD_WRKSRC is not easier, why is it
bpm?
I am also confused by this. What would I be setting to yes, to resolve this
issue?
>
>bsd.port.mk:
># NO_WRKSUBDIR - Assume port unpacks directly into ${WRKDIR}.
It does do this, and I have made this change, but haven't pushed it yet, as
I would like to work out the style issue first.
>
>> Seems silly when bpm supports a different BUILD worksource.
>
>I am sorry but I don't understand this because I don't use bpm.
I am referring to bsd.port.mk
>
>> >...
>> >EXTRACT_CMD= ${TAR}
>> >EXTRACT_BEFORE_ARGS= xf
>> >EXTRACT_AFTER_ARGS= -C ${WRKDIR}
>>
>> Why on these, as well? I'm not using zip, and zip is in different
>> locations based on different releases of the Operating System.
>
>Please see above. Besides, what made you think bsdtar is available
>and able extract a JAR file on "different releases of the Operating
>System"? ;-)
There are instances of using zip that don't work on 7.x with jar files. I
have addressed this in a number of ports as a result of pointyhat failures.
Thanks,
Jason
--
Jason Helfman | FreeBSD Committer
jgh@FreeBSD.org | http://people.freebsd.org/~jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120320183828.GB13507>