Date: Wed, 8 Mar 2023 21:12:20 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions Message-ID: <CANCZdfrxGAOKOUGKLiz0up%2Bk1m0ZiVupXfDFP1rzF2-6gpujbA@mail.gmail.com> In-Reply-To: <CAPyFy2DBaxyGefuVJou17%2BFo=Bj9eZ2YNzUy8CjY%2BmO%2BEHXDnA@mail.gmail.com> References: <202303082331.328NViDn050541@gitrepo.freebsd.org> <dac0dcf2-a104-e326-43ae-91a084b61623@FreeBSD.org> <CAPyFy2DBaxyGefuVJou17%2BFo=Bj9eZ2YNzUy8CjY%2BmO%2BEHXDnA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Mar 8, 2023 at 7:13 PM Ed Maste <emaste@freebsd.org> wrote: > On Wed, 8 Mar 2023 at 18:34, John Baldwin <jhb@freebsd.org> wrote: > > > > On 3/8/23 3:31 PM, Ed Maste wrote: > > > The branch main has been updated by emaste: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1 > > > > > > commit c581962414edfc26796319ccc988647b08b03ce1 > > > Author: Ed Maste <emaste@FreeBSD.org> > > > AuthorDate: 2023-03-07 18:49:23 +0000 > > > Commit: Ed Maste <emaste@FreeBSD.org> > > > CommitDate: 2023-03-08 23:30:45 +0000 > > > > > > src.conf.5: Add some WITH_/WITHOUT_ option descriptions > > > > > > Reviewed by: markj, brooks > > > Sponsored by: The FreeBSD Foundation > > > Differential Revision: https://reviews.freebsd.org/D38961 > > > > Hah, I was just working on those, but I noticed that we don't have > > duplicate WITH/WITHOUT options for other options so kind of punted. > > We already had (some) duplicates for options which have different > defaults per architecture, like LLDB. These ones (plus > WITH_LOADER_VERIEXEC_VECTX) were the only ones missing when running > `make makeman`. > > I think there is some value to providing the list of architectures for > WITH_ and WITHOUT_ defaults. Perhaps we could rework makeman to look > also for a single option description (without WITH_/WITHOUT_ prefix), > producing something like: > > WITH_LLDB / WITHOUT_LLDB > Control building of the LLDB debugger. > > WITH_LLDB is the default setting on amd64/amd64, arm64/aarch64, > i386/i386, powerpc/powerpc and powerpc/powerpc64. > > WITHOUT_LLDB is the default setting on arm/armv6, arm/armv7, > mips/mips, > mips/mips64, riscv/riscv64 and riscv/riscv64sf. > Yea, there's no reason to have the description twice... Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 8, 2023 at 7:13 PM Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 8 Mar 2023 at 18:34, John Baldwin <<a href="mailto:jhb@freebsd.org" target="_blank">jhb@freebsd.org</a>> wrote:<br> ><br> > On 3/8/23 3:31 PM, Ed Maste wrote:<br> > > The branch main has been updated by emaste:<br> > ><br> > > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1</a><br>; > ><br> > > commit c581962414edfc26796319ccc988647b08b03ce1<br> > > Author: Ed Maste <emaste@FreeBSD.org><br> > > AuthorDate: 2023-03-07 18:49:23 +0000<br> > > Commit: Ed Maste <emaste@FreeBSD.org><br> > > CommitDate: 2023-03-08 23:30:45 +0000<br> > ><br> > > src.conf.5: Add some WITH_/WITHOUT_ option descriptions<br> > ><br> > > Reviewed by: markj, brooks<br> > > Sponsored by: The FreeBSD Foundation<br> > > Differential Revision: <a href="https://reviews.freebsd.org/D38961" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D38961</a><br>; ><br> > Hah, I was just working on those, but I noticed that we don't have<br> > duplicate WITH/WITHOUT options for other options so kind of punted.<br> <br> We already had (some) duplicates for options which have different<br> defaults per architecture, like LLDB. These ones (plus<br> WITH_LOADER_VERIEXEC_VECTX) were the only ones missing when running<br> `make makeman`.<br> <br> I think there is some value to providing the list of architectures for<br> WITH_ and WITHOUT_ defaults. Perhaps we could rework makeman to look<br> also for a single option description (without WITH_/WITHOUT_ prefix),<br> producing something like:<br> <br> WITH_LLDB / WITHOUT_LLDB<br> Control building of the LLDB debugger.<br> <br> WITH_LLDB is the default setting on amd64/amd64, arm64/aarch64,<br> i386/i386, powerpc/powerpc and powerpc/powerpc64.<br> <br> WITHOUT_LLDB is the default setting on arm/armv6, arm/armv7, mips/mips,<br> mips/mips64, riscv/riscv64 and riscv/riscv64sf.<br></blockquote><div><br></div><div>Yea, there's no reason to have the description twice...</div><div><br></div><div>Warner </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrxGAOKOUGKLiz0up%2Bk1m0ZiVupXfDFP1rzF2-6gpujbA>