Date: Fri, 27 Feb 2026 08:57:48 +0100 From: Michael Tuexen <tuexen@FreeBSD.org> To: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 454212b9718b - main - sctp: fix so_proto when peeling off a socket Message-ID: <320FFBF5-040E-4EA7-A960-8DC3A632744B@FreeBSD.org> In-Reply-To: <DA9B5022-602F-4720-9473-191B1A20B6B5@gmail.com> References: <699ef25d.42e41.7579887f@gitrepo.freebsd.org> <DA9B5022-602F-4720-9473-191B1A20B6B5@gmail.com>
index | next in thread | previous in thread | raw e-mail
> On 27. Feb 2026, at 04:46, Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > Hi Michael! > >> On Feb 25, 2026, at 5:00 AM, Michael Tuexen <tuexen@FreeBSD.org> wrote: >> >> The branch main has been updated by tuexen: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=454212b9718b55b43781f81bef252658e20e0fd3 > > … > >> @@ -171,7 +173,7 @@ sys_sctp_peeloff(struct thread *td, struct sctp_peeloff_args *uap) >> td->td_retval[0] = fd; >> >> CURVNET_SET(head->so_vnet); >> - so = sopeeloff(head); >> + so = sopeeloff(head, &sctp_stream_protosw); > > > This part of the change broke LINT-NOINET because sctp_stream_protosw is only defined in the INET case. I didn’t dig into the SCTP syscalls too far, but I think that the right protocol needs to be picked per the address family, right? Fixed in https://cgit.FreeBSD.org/src/commit/?id=6bd97e9e01ff159eef49b2521fdbe67d5db10d95 <https://cgit.freebsd.org/src/commit/?id=6bd97e9e01ff159eef49b2521fdbe67d5db10d95>; Thanks again for reporting and sorry for breaking the build. Best regards Michael > Thanks! > -Enjihome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?320FFBF5-040E-4EA7-A960-8DC3A632744B>