Date: Thu, 05 Dec 2013 10:53:50 +0100 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258930 - head/sys/dev/drm2 Message-ID: <52A04D2E.2040705@FreeBSD.org> In-Reply-To: <201312041518.33731.jhb@freebsd.org> References: <201312041904.rB4J4vbM043709@svn.freebsd.org> <201312041518.33731.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 04.12.2013 21:18, John Baldwin wrote: > On Wednesday, December 04, 2013 2:04:57 pm Jean-Sebastien Pedron wrote: >> Author: dumbbell >> Date: Wed Dec 4 19:04:56 2013 >> New Revision: 258930 >> URL: http://svnweb.freebsd.org/changeset/base/258930 >> >> Log: >> drm: Read PCIER_LINK_CAP/PCIER_LINK_CAP2 from the PCI bridge >> >> Before this fix, capabilities were read from vgapci and were incorrect. > > Eh, vgapci is the right place to read this. The LINK_CAP here is telling > you the width of the slot you are plugged into, not the width of the card > that is plugged into the slot. I'm sorry, my knowledge of PCI is very limited (still learning) and I don't understand your comment. Could you please expand on it? I believe this code has the correct result (eg, same result as Linux 3.8 on the same computer), but maybe I'm doing it wrong and I was just lucky. -- Jean-Sébastien Pédron [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKgTTIACgkQa+xGJsFYOlN9PACfdls9nEejg1vd9fEJ1Oy1r3cd mSEAoMCCXW4WL7c6LYQ8R//jCgUO+nIt =aSwE -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52A04D2E.2040705>