Date: Sun, 18 Mar 2001 13:15:30 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> Cc: Matt Dillon <dillon@earth.backplane.com>, John Baldwin <jhb@FreeBSD.ORG>, arch@FreeBSD.ORG Subject: Re: Proposal for the CPU interrupt API Message-ID: <Pine.BSF.4.21.0103181302180.25280-100000@besplex.bde.org> In-Reply-To: <200103172342.PAA59546@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 17 Mar 2001, Rodney W. Grimes wrote: > > :and by otherwise I included comments in code. Take this one for example: > > :>From sys/i386/isa/if_sr.c > > : /* > > : * XXX Disable all interrupts for now. I think if you are using the > > : * dmac you don't use these interrupts. > > : */ > > : SRC_PUT8(hc->sca_base, msci->ie0, 0); > > : SRC_PUT8(hc->sca_base, msci->ie1, 0x0C); > > : > > :writting 0x0C to msci->ie1 does NOT disable all interrupts!!! > > > > Well, those XXX's seem to indicate that the author wasn't so sure about > > what he was doing either. Quite a useful comment, I think! > > The XXX is more than likely with regards to the ``I think if you are...'' > part of the comment. (And it is wrong about that as well, you need to > use most of the interrupts, even when using the dmac, to deal with things > like DMA underruns and overruns.) Anyway, this has nothing to do with the subject of this thread. "all" in this context means "all interrupts for this device". Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0103181302180.25280-100000>