Date: Tue, 5 Nov 2019 10:53:56 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r354357 - head/tests/sys/netinet6/frag6 Message-ID: <201911051053.xA5Arutf044828@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: bz Date: Tue Nov 5 10:53:55 2019 New Revision: 354357 URL: https://svnweb.freebsd.org/changeset/base/354357 Log: frag6 tests: set end to catch timeout as error There are times when we have to wait for reply packets. There are either an ICMPv6 (error) reply or the expiration timeout. In these cases synchonous ICMPv6 replies should arrive, always, unless the packet is lost. Due to errors experienced with the test software sending an invlaid request on at least i386 (*) these packets are not generated. That means we are waiting for a long time for the replies or even timeout the test case. Manually set the "End" flag on these test cases as well, so they do fail rather than timeout as the sniffer timeout happens. This improves debugging options, reflects the error properly, and saves time on each test suit run. (*) The real cause for that is still to be found (see the referenced PRs) PR: 241493, 239380 MFC after: 2 weeks Sponsored by: Netflix Modified: head/tests/sys/netinet6/frag6/frag6_02.py head/tests/sys/netinet6/frag6/frag6_04.py Modified: head/tests/sys/netinet6/frag6/frag6_02.py ============================================================================== --- head/tests/sys/netinet6/frag6/frag6_02.py Tue Nov 5 08:53:40 2019 (r354356) +++ head/tests/sys/netinet6/frag6/frag6_02.py Tue Nov 5 10:53:55 2019 (r354357) @@ -98,6 +98,7 @@ def main(): sp.sendp(ip6f01, iface=args.sendif[0], verbose=False) sleep(0.10) + sniffer.setEnd() sniffer.join() if not sniffer.foundCorrectPacket: sys.exit(1) Modified: head/tests/sys/netinet6/frag6/frag6_04.py ============================================================================== --- head/tests/sys/netinet6/frag6/frag6_04.py Tue Nov 5 08:53:40 2019 (r354356) +++ head/tests/sys/netinet6/frag6/frag6_04.py Tue Nov 5 10:53:55 2019 (r354357) @@ -95,6 +95,7 @@ def main(): sp.sendp(ip6f01, iface=args.sendif[0], verbose=False) sleep(0.10) + sniffer.setEnd() sniffer.join() if not sniffer.foundCorrectPacket: sys.exit(1)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911051053.xA5Arutf044828>