Date: Fri, 30 Dec 2005 12:52:27 -0500 From: Martin Cracauer <cracauer@cons.org> To: freebsd-current@FreeBSD.ORG Subject: Re: fetch extension - use local filename from content-dispositionheader (new diff) Message-ID: <20051230125227.A33408@cons.org> In-Reply-To: <20051230035724.GA52167@nagual.pp.ru>; from ache@FreeBSD.ORG on Fri, Dec 30, 2005 at 06:57:24AM %2B0300 References: <20051229221459.A17102@cons.org> <030d01c60cf1$db80a290$1200a8c0@gsicomp.on.ca> <20051230035724.GA52167@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Allright. Polishing: - disallow "/" anywhere in the filename - disallow "." at the beginning - replace all chars less than ' ' or > 127 with "_" - use a static buffer of size [MAX_PATH] instead of allocated memory, to be fail-safe against memory leaks from other applications using libfetch - typo corrected, style fixes, manual entries I also added a "-Q" flag which will print the resulting filename to stdout. This is useful in scripting. Diff on http:/www.cons.org/tmp/freebsd-fetch-O2.diff When discussing, keep in mind that the user has to explicity give the -O option (there is no environment variable to permanently turn this on) and that the implications of the -O options are very clear and simple. And that the main use of this is for folks who have to go through a gazillion of Bugzilla attachments all name "customer-errlog.20051220" etc, and there is no other way to download them in a name-preserving manner than interactively opening them in Mozilla and saving them. Before we randomize the list even more I would say I'd like to hear from the security officer if there is concern left. Myself I have no way to form conflicting user opinions into a decision. For the reasons above I plan to go forward if not vetoed. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer@cons.org> http://www.cons.org/cracauer/ FreeBSD - where you want to go, today. http://www.freebsd.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051230125227.A33408>