Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Jun 2022 00:45:01 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 294386e0f7c0 - stable/13 - kqueue tests: Simplify the test runner
Message-ID:  <202206080045.2580j1x5060714@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=294386e0f7c008a6717801e90488e23e7e85337e

commit 294386e0f7c008a6717801e90488e23e7e85337e
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-05-25 00:17:04 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2022-06-08 00:42:28 +0000

    kqueue tests: Simplify the test runner
    
    Just invoke the test program directly instead of trying to convert its
    output to TAP format.  The test suite is all or nothing; there's no way
    to enumerate individual test cases, so there's no advantage in trying to
    massage its output, and doing so throws away information that's useful
    when diagnosing test failures.
    
    Sponsored by:   The FreeBSD Foundation
    
    (cherry picked from commit 68fe988a40ca5dedec426735f52471d9af7bddbd)
---
 ObsoleteFiles.inc                         |  2 ++
 tests/sys/kqueue/libkqueue/Makefile       |  6 ++----
 tests/sys/kqueue/libkqueue/kqueue_test.sh | 17 -----------------
 3 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
index 4b4b4bb96a65..d4f7d44b27b4 100644
--- a/ObsoleteFiles.inc
+++ b/ObsoleteFiles.inc
@@ -36,6 +36,8 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 20220607: libkqueue test updates
+OLD_FILES+=usr/tests/sys/kqueue/libkqueue/kqtest
 # 20220604: new clang import which bumps version from 13.0.0 to 14.0.3
 OLD_FILES+=usr/lib/clang/13.0.0/include/cuda_wrappers/algorithm
 OLD_FILES+=usr/lib/clang/13.0.0/include/cuda_wrappers/complex
diff --git a/tests/sys/kqueue/libkqueue/Makefile b/tests/sys/kqueue/libkqueue/Makefile
index cc29e35aa510..869b71209c4d 100644
--- a/tests/sys/kqueue/libkqueue/Makefile
+++ b/tests/sys/kqueue/libkqueue/Makefile
@@ -4,11 +4,9 @@ TESTSDIR=	${TESTSBASE}/sys/kqueue/libkqueue
 BINDIR=		${TESTSDIR}
 
 # libkqueue and test suite by Mark Heily <mark@heily.com>
-TAP_TESTS_SH=	kqueue_test
+PLAIN_TESTS_C=	kqueue_test
 
-PROGS=	kqtest
-
-SRCS.kqtest=		\
+SRCS.kqueue_test=	\
 	main.c		\
 	read.c		\
 	timer.c		\
diff --git a/tests/sys/kqueue/libkqueue/kqueue_test.sh b/tests/sys/kqueue/libkqueue/kqueue_test.sh
deleted file mode 100644
index 3185d826c7dd..000000000000
--- a/tests/sys/kqueue/libkqueue/kqueue_test.sh
+++ /dev/null
@@ -1,17 +0,0 @@
-#!/bin/sh
-# $FreeBSD$
-
-i=1
-"$(dirname $0)/kqtest" | while read line; do
-	echo $line | grep -q passed
-	if [ $? -eq 0 ]; then
-		echo "ok - $i $line"
-		: $(( i += 1 ))
-	fi
-
-	echo $line | grep -q 'tests completed'
-	if [ $? -eq 0 ]; then
-		echo -n "1.."
-		echo $line | cut -d' ' -f3
-	fi
-done



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202206080045.2580j1x5060714>