Date: Wed, 4 Sep 2019 10:21:40 -0400 From: Allan Jude <allanjude@freebsd.org> To: Alan Somers <asomers@freebsd.org>, Andriy Gapon <avg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r351812 - head/usr.sbin/mpsutil Message-ID: <8edfc58e-21c8-3233-2167-2d83af6c3a5f@freebsd.org> In-Reply-To: <CAOtMX2h7tNjawCNcMO_GzBe62YUO8TRb2rP1ERakPr_rW8mFFA@mail.gmail.com> References: <201909041347.x84Dlcds017291@repo.freebsd.org> <CAOtMX2h7tNjawCNcMO_GzBe62YUO8TRb2rP1ERakPr_rW8mFFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ Content-Type: multipart/mixed; boundary="1mnSuyVn6QnUTBxuNJCg0gWkCYyMwajep"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Alan Somers <asomers@freebsd.org>, Andriy Gapon <avg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Message-ID: <8edfc58e-21c8-3233-2167-2d83af6c3a5f@freebsd.org> Subject: Re: svn commit: r351812 - head/usr.sbin/mpsutil References: <201909041347.x84Dlcds017291@repo.freebsd.org> <CAOtMX2h7tNjawCNcMO_GzBe62YUO8TRb2rP1ERakPr_rW8mFFA@mail.gmail.com> In-Reply-To: <CAOtMX2h7tNjawCNcMO_GzBe62YUO8TRb2rP1ERakPr_rW8mFFA@mail.gmail.com> --1mnSuyVn6QnUTBxuNJCg0gWkCYyMwajep Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2019-09-04 09:50, Alan Somers wrote: > On Wed, Sep 4, 2019 at 7:47 AM Andriy Gapon <avg@freebsd.org > <mailto:avg@freebsd.org>> wrote: >=20 > Author: avg > Date: Wed Sep=C2=A0 4 13:47:38 2019 > New Revision: 351812 > URL: https://svnweb.freebsd.org/changeset/base/351812 >=20 > Log: > =C2=A0 mpsutil slot set status >=20 > =C2=A0 This code has been written as a proof of concept, but I thin= k that it > =C2=A0 can be useful in general.=C2=A0 It allows to set the status = of an enclosure > =C2=A0 slot.=C2=A0 Practically, this means controlling whatever slo= t status > LEDs the > =C2=A0 enclosure provides.=C2=A0 At present, the new command does n= ot have sanity > =C2=A0 checks or any conveniences.=C2=A0 That means that it is poss= ible to > issue the > =C2=A0 command for an invalid slot and an enclosure.=C2=A0 But the = worst I > have seen > =C2=A0 happening is either the command failing or simply being igno= red.=C2=A0 > Also, > =C2=A0 at the moment, the status has to be specified as a numeric b= it mask. > =C2=A0 The bit definitions can be found in sys/dev/mps/mpi/mpi2_ini= t.h, they > =C2=A0 are prefixed with MPI2_SEP_REQ_SLOTSTATUS_.=C2=A0 The only w= ay to address a > =C2=A0 slot is by the enclosure handle and the slot number.=C2=A0 B= oth are readily > =C2=A0 available from mpsutil show commands. >=20 > =C2=A0 So, future enhancements could include alternative ways to ad= dress > a slot > =C2=A0 (e.g., by a disk handle or a disk device name) and human fri= endly > names > =C2=A0 for slot statuses. >=20 > =C2=A0 The new command is useful alternative to 'sas2ircu locate' c= ommand. > =C2=A0 First, sas2ircu is a proprietary blob.=C2=A0 Second, it supp= orts > setting only > =C2=A0 locate / identify status bit. >=20 > =C2=A0 Tested on HP H220 running LSI IT firmware 20.x. >=20 > =C2=A0 Reviewed by:=C2=A0 bapt > =C2=A0 MFC after:=C2=A0 =C2=A0 3 weeks > =C2=A0 Differential Revision:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://re= views.freebsd.org/D20535 >=20 > Added: > =C2=A0 head/usr.sbin/mpsutil/mps_slot.c=C2=A0 =C2=A0(contents, prop= s changed) > Modified: > =C2=A0 head/usr.sbin/mpsutil/Makefile > =C2=A0 head/usr.sbin/mpsutil/mps_cmd.c > =C2=A0 head/usr.sbin/mpsutil/mpsutil.h >=20 >=20 > Is this redundant with sesutil, or does it work on different kinds of > enclosures?=C2=A0 mpsutil's method will work on direct-attach backplanes and enclosures, where sesutil only works if there is an expander that provides the SES service. --=20 Allan Jude --1mnSuyVn6QnUTBxuNJCg0gWkCYyMwajep-- --LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJdb8iCAAoJEBmVNT4SmAt+deIQAIvrNYEBZIUiq+w00kFaZTKC ggQz7+xpNHXms09TBtDqv+1knD1RjW/2PL4VsE1yeL1QGYtkY9ruqWeZrp8Jpn40 bW3AiVjC6A7JSo/ApTODue7h7UEqy/SvOYlvxObCHULIwhfMpMKLVavFKnrI3jrN b4IonjYmHqFoVvWeHKPHoySwbGXuf29lJYB2iNmuoFqg5lXiqEVfzH5wHPCSx5f9 CAoy2Q+PfyE6WN8F1vnmPcnBXK6bULlygpjC3pKLyPQNZk22hHQScBzb3gaeOhdn Ti/k6Tbh5XJrcOZNHWa+xUeaD7ejHxuLNS9Bm4DKa71oi+itUvJXpqUNbQHBepeQ pQ66U2wwD1hzBUuluvAwAOtOzyAPtKRhO4Z8IXtCyfIhah2GG7uv+7RHnBqmNLBE CFL2CD3xEU0QqHJGlfW5P+zGz7Yc3WLNxM9NIGPDv05r41iVU4z5BdQQUGcGyOeL Aol2ru75MXwzg4IG9Jws5NCxdHkA1udoVBysftirpOQ50NHiMP5Z0/eyHtzK3d7Y NZ8ximmT166oty2Hb01vz/UODoYCSdpeADn6ZWgVkCdaE3euWstRP4VbLkUX1L6C LdbvOzLmtF9vFe+GotrYiFFIRVBXOJWWbPq2MgzE9smgtZS2bZc/5empVyCzIO58 9s5mXlt994UOynRqwOAd =lDiF -----END PGP SIGNATURE----- --LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8edfc58e-21c8-3233-2167-2d83af6c3a5f>