Date: Tue, 27 Apr 2010 23:23:40 GMT From: Ondra Knezour <knezour@weboutsourcing.cz> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/146100: sysutils/smartmontools: Add support for periodic ciss devices health monitoring Message-ID: <201004272323.o3RNNe7N066621@www.freebsd.org> Resent-Message-ID: <201004272330.o3RNU1Dq061682@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 146100
>Category: ports
>Synopsis: sysutils/smartmontools: Add support for periodic ciss devices health monitoring
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 27 23:30:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Ondra Knezour
>Release: 7.2-STABLE
>Organization:
>Environment:
FreeBSD sb.weboutsourcing.cz 7.2-STABLE FreeBSD 7.2-STABLE #0: Mon Jun 8 22:16:18 CEST 2009 root@sb.weboutsourcing.cz:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Current version of /usr/local/etc/periodic/smart can check SMART health status only for ad/da/twa/twe devices. Attached patch extends its support for ciss devices.
Additionally, review please my change of handling of cd* devices.
>How-To-Repeat:
>Fix:
Attached unified diff works fine for me.
Patch attached with submission follows:
--- /usr/ports/sysutils/smartmontools/files/smart.in 2010-03-10 14:12:53.000000000 +0100
+++ /usr/local/etc/periodic/daily/smart.in 2010-04-28 01:04:43.000000000 +0200
@@ -40,14 +40,16 @@
device="${device#/dev/}"
devflags=""
case ${device} in
- cd*) continue
+ cd*) ;;
+ tw[ae]*) devflags="-d3ware,${device##tw[ae][0-9]*,}"
+ device="/dev/${device%,[0-9]*}"
;;
- tw[ae]*) devflags="-d3ware,${device#tw[ae][0-9]*,}"
- device="/dev/${device%,[0-9]*}"
+ ciss*) devflags="-dcciss,${device##ciss[0-9]*,}"
+ device="/dev/${device%,[0-9]*}"
;;
/*) ;;
*) device="/dev/${device}"
- ;;
+ ;;
esac
if [ -e ${device} ]; then
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201004272323.o3RNNe7N066621>