Date: Thu, 8 Aug 2013 03:06:44 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r254082 - head/sys/net80211 Message-ID: <CAJ-VmomOjQ8qaB2Xor67s_GOEPUir_o_k9sLUj1P%2BZmsF=tYbg@mail.gmail.com> In-Reply-To: <20130808092343.GP20104@FreeBSD.org> References: <201308080509.r7859aWv084743@svn.freebsd.org> <20130808092343.GP20104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, I'm going to eventually nuke OACTIVE. It just doesn't hold any meaning nowdays. Having OACTIVE serialised behind the iflock doesn't actuallly help as much as it used to - because there's multiple concurrent TX path entry points, it's very possible that OACTIVE will get set in one TXing thread during the _middle_ of the execution of another TX thread. That's why you need some kind of higher level serialisation or locking around the TX path to have it make any sense. -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomOjQ8qaB2Xor67s_GOEPUir_o_k9sLUj1P%2BZmsF=tYbg>