Date: Tue, 18 Apr 2023 09:30:09 -0400 From: Matteo Riondato <matteo@freebsd.org> To: dev-commits-src-main@freebsd.org Subject: Re: git: c3fbd9c6212c - main - Revert "stand: Remove double words in source code comments" Message-ID: <20230418133009.iiaz6l3fsjppybqc@ubertino.local> In-Reply-To: <202304180609.33I69iRq089390@gitrepo.freebsd.org> References: <202304180609.33I69iRq089390@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--n2wfaq6c23aiuwsc Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-04-18 at 02:09 EDT, Gordon Bergling <gbe@FreeBSD.org> wrote: >The branch main has been updated by gbe: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc3fbd9c6212cad2634f5958ffec= 0370166ec7204 > >commit c3fbd9c6212cad2634f5958ffec0370166ec7204 >Author: Gordon Bergling <gbe@FreeBSD.org> >AuthorDate: 2023-04-18 06:08:35 +0000 >Commit: Gordon Bergling <gbe@FreeBSD.org> >CommitDate: 2023-04-18 06:08:35 +0000 > > Revert "stand: Remove double words in source code comments" > > The sentence, "The base address that we the boot0 code to to run it." > is correct. > > Reported by: jrtc27 > > This reverts commit b12ccd0bb1b37f32e972bb3e945e4025fe409e2f. >--- > stand/i386/boot0/Makefile | 2 +- > stand/libsa/zfs/zfsimpl.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/stand/i386/boot0/Makefile b/stand/i386/boot0/Makefile >index dad078fd6f71..1453f17751b9 100644 >--- a/stand/i386/boot0/Makefile >+++ b/stand/i386/boot0/Makefile >@@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?=3D 0x8f > # 0xb6 (182d) corresponds to 10 seconds. > BOOT_BOOT0_TICKS?=3D 0xb6 > >-# The base address that we the boot0 code to run it. Don't change this >+# The base address that we the boot0 code to to run it. Don't change this I really think this comment needs a verb (load), as observed by jrtc27@. Even better (?), as danfe@ suggested, it should possibly be rephrased=20 as: "The base address where we load the boot0 code to run it. Don't change=20 this." or something along those lines. Thanks, Matteo --n2wfaq6c23aiuwsc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmQ+m1wTGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVAdzGEADQpIRMwJxFlrj0D/phYBkB8ebr4BmL ugFtMpZ1ShXHc1lr0HSm8h38/V+FeYx9NjAGjpcWPOd1rNAtCt8w2GADFYTZ+wfI vw8E3PmRDBkWdvBhYXo+/0McjDGxzSFJCVMP5tZ2mjrEFeOluku0iiFndJ7PPiBV pvalVSarEKMhA5AAnzvJiE8bxpI8MhuSmzEkL+8kZks4oKsz5BUR4MTTSUAcGeCY oRtDEnfQBw53tq7TJmaqbRq0yb95PHHFiUOxd9S8qyNl7J8at6GH1SQrDJaYfmK7 fCQkhmJA8xBLdEZLN6kGZ6hPbWHd2Qox8T5T7dMMz6i38xzNTe3uoPpyS4lNklWJ +uq3ERgEHIOsMaaAG/Vqt01pQbkDtmu3H7SNcvb/q1TgDAShlrqvkG9YsUZZs8VO PYQx0T9lHTI8IFKq+IJgRs/NBMhz3UXYnagt5cYb4Vvq2nzdtHua6I6QSydKyPYt ap+t4qdOVwwIVPA08zVKgcFFLLAFgD1u5pyAJ/Qel9ysyNGdWuthxGrw96C4Z4BV 51kiF4CJxyfqAWVVVi1EfcUjT2AwrKJfho+koOVTNi77Vr9F0Z8HWM45oNuKMJYn GAQSswsV5w9Ve41DTWlehEy6fEuGsaSiNrHhJ7kFHjPF1FnlzZNFHpDh9idqXbCj hoJvjU0N8LMJjw== =bNGm -----END PGP SIGNATURE----- --n2wfaq6c23aiuwsc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230418133009.iiaz6l3fsjppybqc>