Date: Sun, 23 May 2010 00:35:26 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: mav@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208183 - in head/sys: conf modules/mvs Message-ID: <20100523.003526.1142818667088610804.imp@bsdimp.com> In-Reply-To: <201005170351.o4H3pvuG006399@svn.freebsd.org> References: <201005170351.o4H3pvuG006399@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <201005170351.o4H3pvuG006399@svn.freebsd.org> Alexander Motin <mav@FreeBSD.org> writes: : Author: mav : Date: Mon May 17 03:51:57 2010 : New Revision: 208183 : URL: http://svn.freebsd.org/changeset/base/208183 : : Log: : Make mvs_if.c to not be always linked statically into the kernel. : Link it same way as mvs.c. A consequence of this will be that if you kldload modules that use the mvs_if.m services, but don't have the mvs.ko module, then you'll have problems. I ran into this with pccard/pcic/pccbb/cardbus/*pccard.c drivers so I compiled pccard_if.m into the kernel statically. I don't know if that's a big deal for you, but it is why things like this are usually linked in statically. Warner : Modified: : head/sys/conf/files : head/sys/modules/mvs/Makefile : : Modified: head/sys/conf/files : ============================================================================== : --- head/sys/conf/files Mon May 17 02:44:51 2010 (r208182) : +++ head/sys/conf/files Mon May 17 03:51:57 2010 (r208183) : @@ -1294,7 +1294,7 @@ dev/mpt/mpt_raid.c optional mpt : dev/mpt/mpt_user.c optional mpt : dev/msk/if_msk.c optional msk inet : dev/mvs/mvs.c optional mvs : -dev/mvs/mvs_if.m standard : +dev/mvs/mvs_if.m optional mvs : dev/mvs/mvs_pci.c optional mvs pci : dev/mwl/if_mwl.c optional mwl : dev/mwl/if_mwl_pci.c optional mwl pci : : Modified: head/sys/modules/mvs/Makefile : ============================================================================== : --- head/sys/modules/mvs/Makefile Mon May 17 02:44:51 2010 (r208182) : +++ head/sys/modules/mvs/Makefile Mon May 17 03:51:57 2010 (r208183) : @@ -3,7 +3,7 @@ : .PATH: ${.CURDIR}/../../dev/mvs : : KMOD= mvs : -SRCS= mvs.c mvs_pci.c mvs.h mvs_if.h device_if.h bus_if.h pci_if.h opt_cam.h : +SRCS= mvs.c mvs_pci.c mvs.h mvs_if.c mvs_if.h device_if.h bus_if.h pci_if.h opt_cam.h : : MFILES= kern/bus_if.m kern/device_if.m dev/pci/pci_if.m dev/mvs/mvs_if.m : :
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100523.003526.1142818667088610804.imp>