Date: Thu, 01 Oct 2009 20:01:58 -0700 From: Sam Leffler <sam@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis Message-ID: <4AC56D26.4030500@freebsd.org> In-Reply-To: <20091002002534.D21507@delplex.bde.org> References: <200910010243.n912hpSM034846@svn.freebsd.org> <86eipno12p.fsf@ds4.des.no> <20091002002534.D21507@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > On Thu, 1 Oct 2009, [utf-8] Dag-Erling Smørgrav wrote: > >> Coleman Kane <cokane@FreeBSD.org> writes: >>> - if (sc->ndis_80211 && vap) >>> + if ((sc->ndis_80211 != NULL) && (vap != NULL)) >> >> sc->ndis_80211 is an int. NULL is a pointer. > > Also, the number of style bugs was doubled on (almost?) every changed line > by adding 2 sets of unnecessary parentheses. FWIW I simply asked he compare ptr's against NULL. The excessive paren's hurt my eyes too :-) Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AC56D26.4030500>