Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Dec 2025 00:30:45 +0000
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: a3394b6a23fb - main - m4: avoid warnings about too-long initializer strings
Message-ID:  <694dd735.33f57.28621139@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=a3394b6a23fb66ccb7e588129d2465ef8ea26d30

commit a3394b6a23fb66ccb7e588129d2465ef8ea26d30
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2025-12-26 00:30:25 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2025-12-26 00:30:36 +0000

    m4: avoid warnings about too-long initializer strings
    
    Mark `digits` as `__non_string`, to avoid warnings from clang 21 similar
    to:
    
        usr.bin/m4/misc.c:123:27: error: initializer-string for character array is too long, array size is 36 but initializer has size 37 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
          123 |         static char digits[36] = "0123456789abcdefghijklmnopqrstuvwxyz";
              |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    MFC after:      3 days
---
 usr.bin/m4/misc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/usr.bin/m4/misc.c b/usr.bin/m4/misc.c
index 1870323ccb30..3091f2ad1f9e 100644
--- a/usr.bin/m4/misc.c
+++ b/usr.bin/m4/misc.c
@@ -120,7 +120,8 @@ pbnum(int n)
 void
 pbnumbase(int n, int base, int d)
 {
-	static char digits[36] = "0123456789abcdefghijklmnopqrstuvwxyz";
+	static char digits[36] __nonstring =
+	    "0123456789abcdefghijklmnopqrstuvwxyz";
 	unsigned int num;
 	int printed = 0;
 


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?694dd735.33f57.28621139>