Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:05:58 -0000
From:      Kyle Evans <kevans@freebsd.org>
To:        "Rodney W. Grimes" <rgrimes@freebsd.org>
Cc:        Ravi Pokala <rpokala@freebsd.org>, src-committers <src-committers@freebsd.org>,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r345680 - head/sys/conf
Message-ID:  <CACNAnaEEuoJX7vVwE7XqHdwyY1Jrrv1rWLjdF3gt9CGkgYv%2BUg@mail.gmail.com>
In-Reply-To: <201903290534.x2T5Y7v2097332@gndrsh.dnsmgr.net>
References:  <CAF5D833-B3C3-4AD6-9B77-0363C56E93E9@panasas.com> <201903290534.x2T5Y7v2097332@gndrsh.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 29, 2019 at 12:34 AM Rodney W. Grimes
<freebsd@gndrsh.dnsmgr.net> wrote:
>
> > -----Original Message-----
> > From: <owner-src-committers@freebsd.org> on behalf of Kyle Evans <kevans@FreeBSD.org>
> > Date: 2019-03-28, Thursday at 21:00
> > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
> > Subject: svn commit: r345680 - head/sys/conf
> >
> > > Author: kevans
> > > Date: Fri Mar 29 04:00:46 2019
> > > New Revision: 345680
> > > URL: https://svnweb.freebsd.org/changeset/base/345680
> > >
> > > Log:
> > >   NOTES: Use non-default value for BOOT_TAG
> >
> > Why?
> >
> > (I was on IRC when jhb debugged this, but I didn't quite get it; and of course lots of us *weren't* on IRC at the time.)
>
> Yes, please, why is this beeing changed, do I need to revise my .sh that
> was hunting for the old string to use what now?  Or do I need to now
> override this in my KERNCONF files?
>
> I think changing this in stable/12 is a POLA issue.
>
> > Thanks,
> >
> > Ravi (rpokala@)
> >
> > >   Reported by:      jhb
> > >   MFC after:        1 week (except non-empty value in stable/11)
>
> Why is 11 being treated special, or is it that it does not implement
> BOOT_TAG at all?
>
> Does this deserve a RELNOTES Y, or UPDATING entry?
>

The short answer to all of this is "No, no, no" -- see Bruce's
response about the purpose of NOTES, and the NOTES header itself. It's
the kitchen sink, and you can't/won't/don't include the kitchen sink
when you need a pipelet.

11 is special because BOOT_TAG was implemented after stable/11
branched. I MFC'd it because I used it on stable/11, but the MFC had
to result in a no-op to the msgbuf to not violate POLA.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaEEuoJX7vVwE7XqHdwyY1Jrrv1rWLjdF3gt9CGkgYv%2BUg>