Date: Fri, 10 Jun 2022 01:02:01 +0400 From: Sergey Kandaurov <pluknet@gmail.com> To: Jilles Tjoelker <jilles@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: svn commit: r319663 - head/lib/libc/sys Message-ID: <CAE-mSOK%2B6yZncp8HarxyXJwK-gSyaSws7r59_zSY1Se=xWZ06Q@mail.gmail.com> In-Reply-To: <201706072121.v57LLEH2001634@repo.freebsd.org> References: <201706072121.v57LLEH2001634@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, 8 Jun 2017 at 01:21, Jilles Tjoelker <jilles@freebsd.org> wrote: > Author: jilles > Date: Wed Jun 7 21:21:14 2017 > New Revision: 319663 > URL: https://svnweb.freebsd.org/changeset/base/319663 > > Log: > libc: Remove futimens() and utimensat() compat stubs. > > The futimens() and utimensat() compat stubs allowed using these > functions on > kernels that did not have the system calls yet (10.2, old 11-current). > > Also remove the documentation of the [ENOTSUP] error that could occur > with > an old kernel. > > A -DNO_CLEAN build may fail because the depend files refer to the deleted > files. > > Deleted: > head/lib/libc/sys/futimens.c > head/lib/libc/sys/utimensat.c > Modified: > head/lib/libc/sys/Makefile.inc > head/lib/libc/sys/utimensat.2 > > Modified: head/lib/libc/sys/Makefile.inc > > ============================================================================== > --- head/lib/libc/sys/Makefile.inc Wed Jun 7 21:18:28 2017 > (r319662) > +++ head/lib/libc/sys/Makefile.inc Wed Jun 7 21:21:14 2017 > (r319663) > @@ -37,10 +37,6 @@ SRCS+= \ > > SRCS+= getdents.c lstat.c mknod.c stat.c > > -SRCS+= futimens.c utimensat.c > -NOASM+= futimens.o utimensat.o > -PSEUDO+= _futimens.o _utimensat.o > - > SRCS+= pipe.c > > INTERPOSED = \ > > Modified: head/lib/libc/sys/utimensat.2 > > ============================================================================== > --- head/lib/libc/sys/utimensat.2 Wed Jun 7 21:18:28 2017 > (r319662) > +++ head/lib/libc/sys/utimensat.2 Wed Jun 7 21:21:14 2017 > (r319663) > @@ -31,7 +31,7 @@ > .\" @(#)utimes.2 8.1 (Berkeley) 6/4/93 > .\" $FreeBSD$ > .\" > -.Dd January 17, 2016 > +.Dd June 7, 2017 > .Dt UTIMENSAT 2 > .Os > .Sh NAME > @@ -267,10 +267,6 @@ argument is not an absolute path and > is neither > .Dv AT_FDCWD > nor a file descriptor associated with a directory. > -.It Bq Er ENOTSUP > -The running kernel does not support this system call and > -.Dv AT_SYMLINK_NOFOLLOW > -is used with a path relative to a file descriptor. > .El > .Sh SEE ALSO > .Xr chflags 2 , > I believe the compatibility part can be removed too: diff --git a/lib/libc/sys/utimensat.2 b/lib/libc/sys/utimensat.2 index 2af452898c9..53602d68ba8 100644 --- a/lib/libc/sys/utimensat.2 +++ b/lib/libc/sys/utimensat.2 @@ -169,18 +169,6 @@ operate on the current working directory. .El .Sh RETURN VALUES .Rv -std -.Sh COMPATIBILITY -If the running kernel does not support this system call, -a wrapper emulates it using -.Xr fstatat 2 , -.Xr futimesat 2 -and -.Xr lutimes 2 . -As a result, timestamps will be rounded down to the nearest microsecond, -.Dv UTIME_OMIT -is not atomic and -.Dv AT_SYMLINK_NOFOLLOW -is not available with a path relative to a file descriptor. .Sh ERRORS These system calls will fail if: .Bl -tag -width Er [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 8 Jun 2017 at 01:21, Jilles Tjoelker <<a href="mailto:jilles@freebsd.org" target="_blank">jilles@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: jilles<br> Date: Wed Jun 7 21:21:14 2017<br> New Revision: 319663<br> URL: <a href="https://svnweb.freebsd.org/changeset/base/319663" rel="noreferrer" target="_blank">https://svnweb.freebsd.org/changeset/base/319663</a><br>; <br> Log:<br> libc: Remove futimens() and utimensat() compat stubs.<br> <br> The futimens() and utimensat() compat stubs allowed using these functions on<br> kernels that did not have the system calls yet (10.2, old 11-current).<br> <br> Also remove the documentation of the [ENOTSUP] error that could occur with<br> an old kernel.<br> <br> A -DNO_CLEAN build may fail because the depend files refer to the deleted<br> files.<br> <br> Deleted:<br> head/lib/libc/sys/futimens.c<br> head/lib/libc/sys/utimensat.c<br> Modified:<br> head/lib/libc/sys/Makefile.inc<br> head/lib/libc/sys/utimensat.2<br> <br> Modified: head/lib/libc/sys/Makefile.inc<br> ==============================================================================<br> --- head/lib/libc/sys/Makefile.inc Wed Jun 7 21:18:28 2017 (r319662)<br> +++ head/lib/libc/sys/Makefile.inc Wed Jun 7 21:21:14 2017 (r319663)<br> @@ -37,10 +37,6 @@ SRCS+= \<br> <br> SRCS+= getdents.c lstat.c mknod.c stat.c<br> <br> -SRCS+= futimens.c utimensat.c<br> -NOASM+= futimens.o utimensat.o<br> -PSEUDO+= _futimens.o _utimensat.o<br> -<br> SRCS+= pipe.c<br> <br> INTERPOSED = \<br> <br> Modified: head/lib/libc/sys/utimensat.2<br> ==============================================================================<br> --- head/lib/libc/sys/utimensat.2 Wed Jun 7 21:18:28 2017 (r319662)<br> +++ head/lib/libc/sys/utimensat.2 Wed Jun 7 21:21:14 2017 (r319663)<br> @@ -31,7 +31,7 @@<br> .\" @(#)utimes.2 8.1 (Berkeley) 6/4/93<br> .\" $FreeBSD$<br> .\"<br> -.Dd January 17, 2016<br> +.Dd June 7, 2017<br> .Dt UTIMENSAT 2<br> .Os<br> .Sh NAME<br> @@ -267,10 +267,6 @@ argument is not an absolute path and<br> is neither<br> .Dv AT_FDCWD<br> nor a file descriptor associated with a directory.<br> -.It Bq Er ENOTSUP<br> -The running kernel does not support this system call and<br> -.Dv AT_SYMLINK_NOFOLLOW<br> -is used with a path relative to a file descriptor.<br> .El<br> .Sh SEE ALSO<br> .Xr chflags 2 ,<br></blockquote><div><br></div><div><div style="font-family:monospace,monospace" class="gmail_default">I believe the compatibility part can be removed too:</div><div style="font-family:monospace,monospace" class="gmail_default"><br></div><div style="font-family:monospace,monospace" class="gmail_default">diff --git a/lib/libc/sys/utimensat.2 b/lib/libc/sys/utimensat.2<br>index 2af452898c9..53602d68ba8 100644<br>--- a/lib/libc/sys/utimensat.2<br>+++ b/lib/libc/sys/utimensat.2<br>@@ -169,18 +169,6 @@ operate on the current working directory.<br> .El<br> .Sh RETURN VALUES<br> .Rv -std<br>-.Sh COMPATIBILITY<br>-If the running kernel does not support this system call,<br>-a wrapper emulates it using<br>-.Xr fstatat 2 ,<br>-.Xr futimesat 2<br>-and<br>-.Xr lutimes 2 .<br>-As a result, timestamps will be rounded down to the nearest microsecond,<br>-.Dv UTIME_OMIT<br>-is not atomic and<br>-.Dv AT_SYMLINK_NOFOLLOW<br>-is not available with a path relative to a file descriptor.<br> .Sh ERRORS<br> These system calls will fail if:<br> .Bl -tag -width Er<br></div></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOK%2B6yZncp8HarxyXJwK-gSyaSws7r59_zSY1Se=xWZ06Q>