Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Dec 2025 18:18:46 +0000
From:      Jessica Clarke <jrtc27@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 017ebaa60a83 - stable/13 - ofw: Fix inverted bcmp in ofw_bus_node_status_okay
Message-ID:  <69405106.257fd.731a0b67@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/13 has been updated by jrtc27:

URL: https://cgit.FreeBSD.org/src/commit/?id=017ebaa60a8377ec10cb300cfcc6a4ab91b4e27a

commit 017ebaa60a8377ec10cb300cfcc6a4ab91b4e27a
Author:     Jessica Clarke <jrtc27@FreeBSD.org>
AuthorDate: 2024-12-17 20:51:56 +0000
Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
CommitDate: 2025-12-15 17:56:36 +0000

    ofw: Fix inverted bcmp in ofw_bus_node_status_okay
    
    Otherwise this matches any two-character status except for ok.
    
    Fixes:          e5e94d2de987 ("Expand OpenFirmware API with ofw_bus_node_status_okay method")
    MFC after:      1 week
    
    (cherry picked from commit e1060f6dfd80b34cab6d439bf7420ad686ddc8f1)
---
 sys/dev/ofw/ofw_bus_subr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/ofw/ofw_bus_subr.c b/sys/dev/ofw/ofw_bus_subr.c
index 844b7acaf957..3da754f66e76 100644
--- a/sys/dev/ofw/ofw_bus_subr.c
+++ b/sys/dev/ofw/ofw_bus_subr.c
@@ -197,7 +197,7 @@ ofw_bus_node_status_okay(phandle_t node)
 
 	OF_getprop(node, "status", status, OFW_STATUS_LEN);
 	if ((len == 5 && (bcmp(status, "okay", len) == 0)) ||
-	    (len == 3 && (bcmp(status, "ok", len))))
+	    (len == 3 && (bcmp(status, "ok", len) == 0)))
 		return (1);
 
 	return (0);


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69405106.257fd.731a0b67>