Date: Tue, 10 Feb 2009 21:47:51 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: sam@FreeBSD.org Cc: svn-src-head@FreeBSD.org, mav@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r188464 - head/sys/kern Message-ID: <20090210.214751.-135505687.imp@bsdimp.com> In-Reply-To: <49920E67.60805@freebsd.org> References: <200902102322.n1ANMTgW007393@svn.freebsd.org> <49920E67.60805@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <49920E67.60805@freebsd.org>
Sam Leffler <sam@FreeBSD.org> writes:
: Alexander Motin wrote:
: > Author: mav
: > Date: Tue Feb 10 23:22:29 2009
: > New Revision: 188464
: > URL: http://svn.freebsd.org/changeset/base/188464
: >
: > Log:
: > Check for device_set_devclass() errors and skip driver probe/attach if any.
: > Attach call without devclass set crashes the system.
: >
: > On resume AHCI driver sometimes tries to create duplicate adX device.
: > It is surely his own problem, but IMHO it is not a reason to crash here.
: > Other reasons are also possible.
: >
: >
: Please leave a comment in the code that this is basically a WAR for
: buggy drivers.
I'd personally make it a panic with a real message so that the problem
gets fixed... However, I know that's a pita for people, so I'd do
this only for INVARIANTS kernels. I'd whine *ALWAYS* and not just
behind PDEBUG. This is a bug, and we shouldn't silently paper over
it.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090210.214751.-135505687.imp>