Date: Sun, 7 Oct 2012 00:47:03 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r241295 - head/sys/kern Message-ID: <20121006224702.GA28611@garage.freebsd.pl> In-Reply-To: <201210061950.q96JoNIk028911@svn.freebsd.org> References: <201210061950.q96JoNIk028911@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 06, 2012 at 07:50:23PM +0000, Andriy Gapon wrote: > Author: avg > Date: Sat Oct 6 19:50:23 2012 > New Revision: 241295 > URL: http://svn.freebsd.org/changeset/base/241295 >=20 > Log: > cngetc: use cpu_spinwait to ease the cncheckc loop a tiny bit This doesn't really help me. On machine that I tried something similar, with this patch CPU fan still goes crazy when I enter DDB. What did work for me was to reduce CPU speed to supported minimum. Entering DDB then did not result in CPU fan speed up. If something like this could be done automatically, that would be great. > Reviewed by: julian > MFC after: 10 days >=20 > Modified: > head/sys/kern/kern_cons.c >=20 > Modified: head/sys/kern/kern_cons.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/kern_cons.c Sat Oct 6 19:48:15 2012 (r241294) > +++ head/sys/kern/kern_cons.c Sat Oct 6 19:50:23 2012 (r241295) > @@ -384,7 +384,7 @@ cngetc(void) > if (cn_mute) > return (-1); > while ((c =3D cncheckc()) =3D=3D -1) > - ; > + cpu_spinwait(); > if (c =3D=3D '\r') > c =3D '\n'; /* console input is always ICRNL */ > return (c); --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlBwtOYACgkQForvXbEpPzTygwCfR4XBG3gcSXbnkazBg7zrj4Fh VRcAoMx2pScfI1tko3lRadY+DeD3jtSc =diBM -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121006224702.GA28611>