Date: Tue, 17 May 2016 19:29:34 +0000 From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: maintainer-feedback requested: [Bug 209588] editors/openoffice-4 editors/openoffice-devel: Fix build with libc++ 3.8.0 Message-ID: <bug-209588-25061-aNjV1icpWv@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209588-25061@https.bugs.freebsd.org/bugzilla/> References: <bug-209588-25061@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric <dim@FreeBSD.org> has reassigned Bugzilla Automation <bugzilla@FreeBSD.org>'s request for maintainer-feedback to office@FreeBSD.= org: Bug 209588: editors/openoffice-4 editors/openoffice-devel: Fix build with libc++ 3.8.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209588 --- Description --- Created attachment 170415 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D170415&action= =3Dedit Rename custom round() and use a define to minimize changes During the exp-run in bug 208158, it was found that editors/openoffice-4 [1] and editors/openoffice-devel [2] give errors with libc++ 3.8.0: /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.2/main/vcl/source/glyp= hs/g raphite_layout.cxx:297:21: error: call to 'round' is ambiguous long nXOffset =3D round(fMinX * fScaling); ^~~~~ This is because openoffice defines its own overloaded variant of round(), w= hich is only different in return type from the 'real' round() from <math.h>, so = it is ambiguous (in the C++ lookup sense). Fix this by renaming the custom round() to round_(), and using a define to minimize needed changes in the c= ode. [1] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_= 10h2 9m48s/logs/errors/apache-openoffice-4.1.2_5.log [2] http://package18.nyi.freebsd.org/data/headamd64PR208158-default/2016-05-01_= 10h2 9m48s/logs/errors/apache-openoffice-devel-4.2.1735889_1,4.log
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209588-25061-aNjV1icpWv>