Date: Mon, 03 Feb 2003 13:24:33 -0800 From: Terry Lambert <tlambert2@mindspring.com> To: Maksim Yevmenkin <myevmenk@exodus.net> Cc: hackers@FreeBSD.ORG, questions@FreeBSD.ORG, brian@freebsd.org, doconnor@gsoft.com.au, imp@bsdimp.com Subject: Re: [PATCH] PPP in -direct mode does not execute any chat scripts Message-ID: <3E3EDE11.192ABC3F@mindspring.com> References: <45258A4365C6B24A9832BFE224837D552B1283@sjdcex01.int.exodus.net> <3E3ED4DF.7090904@exodus.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Maksim Yevmenkin wrote: > Please find attached patch that adds new option to the PPP. > > run-scripts-in-direct-mode > Default: Disabled. This allows to run chat scripts in > direct mode. > > did i miss anything? objections? comments? reviews? First comment: run it past Brian Somers <brian@Awfulhak.org>; it's his baby, and he's the active maintainer. Rest of comments: Actually, why doesn't "-direct" allow a chat script by default? The man page doesn't document that as a side-effect of "-direct", only of "-dedicated", but it's been there since the import. Should this really be a "negotiate" section command, rather than just a command or a "set" command? Also, there are only two other commands even have a "-" in them, and both of them only have one (just seems a little long, compared to, say, "rsid" or "direct-with-script", or even "force-script"). Personal preference: don't make it conditional on "-direct", let it also work with "-dedicated", and call it "force-script" or something, instead. The man page should be updated -- including the undocumented side-effect of "-direct" disabling scripts). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-questions" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E3EDE11.192ABC3F>