Date: Wed, 15 Apr 2026 10:32:38 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: np@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Message-ID: <ad_Ltjq8bTD0IL-S@cell.glebi.us> In-Reply-To: <45629508-bfcb-4161-8913-470539b479ad@FreeBSD.org> References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> <ad68HZF99vXubx5J@cell.glebi.us> <45629508-bfcb-4161-8913-470539b479ad@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Wed, Apr 15, 2026 at 10:48:38AM -0400, John Baldwin wrote: J> On 4/14/26 18:13, Gleb Smirnoff wrote: J> > On Tue, Apr 14, 2026 at 06:37:18PM +0000, John Baldwin wrote: J> > J> The branch main has been updated by jhb: J> > J> J> > J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> J> > J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> Author: John Baldwin <jhb@FreeBSD.org> J> > J> AuthorDate: 2026-04-14 18:07:51 +0000 J> > J> Commit: John Baldwin <jhb@FreeBSD.org> J> > J> CommitDate: 2026-04-14 18:07:51 +0000 J> > J> J> > J> tcp_close: Use in6_pcbdisconnect for INET6 sockets J> > J> J> > J> This also fixes the LINT-NOINET builds. J> > J> J> > J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") J> > J> > I think this change is also required. J> > J> > Almost sure it will fix panic observed by Navdeep. J> J> Yes, I had missed that when comparing the two. J> J> Given how similar this functions are, I wonder if in_pcbdisconnect() should be a shared J> method that just has a few AF-specific bits of code? The old in_pcbdrop() function was J> shared and not INET vs INET6 specific. Absolutely. I have this on my list. -- Gleb Smirnoffhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ad_Ltjq8bTD0IL-S>