Date: Fri, 31 May 2002 14:09:25 +0200 From: Bernd Walter <ticso@cicely5.cicely.de> To: Julian Elischer <julian@elischer.org> Cc: FreeBSD current users <current@FreeBSD.ORG> Subject: Re: Seeking OK to commit KSE MIII-again Message-ID: <20020531120925.GL5414@cicely5.cicely.de> In-Reply-To: <20020530191432.GE5414@cicely5.cicely.de> References: <XFMail.20020530105952.jhb@FreeBSD.org> <Pine.BSF.4.21.0205300904260.23153-100000@InterJet.elischer.org> <20020530191432.GE5414@cicely5.cicely.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 30, 2002 at 09:14:33PM +0200, Bernd Walter wrote: > On Thu, May 30, 2002 at 09:20:57AM -0700, Julian Elischer wrote: > > ok, but does anyone other than john (who has commented) have any comments > > about the logic and work in the change? > > > > I'm working on his comments but comments by others would sure be > > appreciated.. > > especially if they actually comment on what I'm trying to do.. > > > > If I can get the changes for the other architectures done, > > I'd like to commit this weekend. HOPEFULLY it shouldn't > > affect normal operations but of course the testing done by two people > > can't hope to equal that which will be done in teh first 24 hours > > once it's committed :-) > > > > once again: > > > > the diffs are at: > > http://people.freebsd.org/~peter/kse.diff > > and > > http://people.freebsd.org/~julian/thediff > > and the diffs I need for other architectures are versions of: > > > > sys/i386/i386/genassym.c (small) > > sys/i386/i386/machdep.c (1 line) > > sys/i386/i386/swtch.s (a few lines) > > sys/i386/i386/trap.c (small) > > sys/i386/i386/vm_machdep.c (largly new functions, we could stub them) > > sys/i386/include/kse.h (new file) > > sys/i386/linux/linux_machdep.c (one line) > > > > Largely these need to be written by someone who is intimately aquainted > > with the register set of the machine in question and knows > > what registers need to be saved to restore a user context correctly. > > I can do the alpha part tomorrow unless someone else already startet. There are problems with the patchset: ../../../kern/kern_proc.c: In function `fill_kinfo_proc': ../../../kern/kern_proc.c:731: `TDS_RUN' undeclared (first use in this function) ../../../kern/kern_proc.c:731: (Each undeclared identifier is reported only once ../../../kern/kern_proc.c:731: for each function it appears in.) ../../../kern/kern_proc.c:733: `SRUN' undeclared (first use in this function) ../../../kern/kern_proc.c:734: `TDS_SLEEP' undeclared (first use in this function) ../../../kern/kern_proc.c:735: `SSLEEP' undeclared (first use in this function) ../../../kern/kern_proc.c:737: `SSTOP' undeclared (first use in this function) ../../../kern/kern_proc.c:739: `SMTX' undeclared (first use in this function) ../../../kern/kern_proc.c:741: `SWAIT' undeclared (first use in this function) ../../../kern/kern_proc.c:743: syntax error before '{' token ../../../kern/kern_proc.c:744: `SZOMB' undeclared (first use in this function) ../../../kern/kern_proc.c:745: syntax error before "else" ../../../kern/kern_proc.c:663: warning: unused variable `tp' ../../../kern/kern_proc.c:664: warning: unused variable `sp' ../../../kern/kern_proc.c:665: warning: unused variable `tv' [...] Line 731 should be TDS_RUNQ I guess. TDS_SLEEP - where is it defined - intended to be TDS_SLP? SRUN, SSLEEP and others: +#ifndef _KERNEL /* Only usable by libkvm for legacy apps */ +#define SIDL 1 /* Process being created by fork. */ +#define SRUN 2 /* Currently runnable. */ +#define SSLEEP 3 /* Sleeping on an address. */ +#define SSTOP 4 /* Process debugging or suspension. */ +#define SZOMB 5 /* Awaiting collection by parent. */ +#define SWAIT 6 /* Waiting for interrupt. */ +#define SMTX 7 /* Blocked on a mutex. */ +#endif Why are they (newly) used in kern_proc.c? IMO they need to be changed to TDS_SLP, ... -- B.Walter COSMO-Project http://www.cosmo-project.de ticso@cicely.de Usergroup info@cosmo-project.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020531120925.GL5414>