Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Jan 2019 11:22:34 -0800
From:      Kirk McKusick <mckusick@mckusick.com>
To:        Andriy Gapon <avg@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r343113 - head/contrib/libc++/include
Message-ID:  <201901171922.x0HJMYaq029738@chez.mckusick.com>
In-Reply-To: <99fd64c3-b3b3-fd50-6370-224a329a3340@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> From:    Andriy Gapon <avg@FreeBSD.org>
> Date:    Thu, 17 Jan 2019 19:05:20 +0200
> To:      Kirk McKusick <mckusick@freebsd.org>, src-committers@freebsd.org,
> 	 svn-src-all@freebsd.org, svn-src-head@freebsd.org
> Subject: Re: svn commit: r343113 - head/contrib/libc++/include
> 
> On 17/01/2019 17:35, Kirk McKusick wrote:
>> -#ifdef ELAST
>> +#if defined(ELAST)
> 
> I think that these are exactly the same, so not sure what the change does.
> 
> -- 
> Andriy Gapon

It was suggested to me that Clang was 'strict' and that it would kick
out the first form. That proved to not be true. To compound my goof, I
missed the actual fix when I did the commit, so had to do -r343115
to get the needed part of the fix in place. I should learn to have my
morning coffee *before* commiting anything.

	Kirk McKusick



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201901171922.x0HJMYaq029738>