Date: Fri, 9 Dec 2011 19:49:40 +0400 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: Max Brazhnikov <makc@issp.ac.ru> Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, Raphael Kubo da Costa <rakuco@freebsd.org>, ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.cmake.mk Message-ID: <20111209154940.GA77124@hades.panopticon> In-Reply-To: <201112091310.18922.makc@issp.ac.ru> References: <201111101950.pAAJoQOb072790@repoman.freebsd.org> <20111209005145.GA1551@hades.panopticon> <201112091310.18922.makc@issp.ac.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
* Max Brazhnikov (makc@issp.ac.ru) wrote: > > > Remove CMAKE_USE_PTHREAD. > > > > > > This has been in area51 since April, and discussions with makc > > > indicate this was only needed when we supported FreeBSD < 7. > > > > > > Approved by: avilla (mentor), portmgr (tabthorpe) > > > Feature safe: yes > > > > > > Revision Changes Path > > > 1.13 +1 -15 ports/Mk/bsd.cmake.mk > > > > This has broken at least devel/bullet. This is not feature safe at all. > > Can you show the build log? http://people.freebsd.org/~amdmi3/bullet_default.log with LDFLAGS=-pthread it builds fine: http://people.freebsd.org/~amdmi3/bullet_ldflags.log Likely that's a correct way to fix it as bullet CMakeLists.txt doesn't do any attempts to detect/use thread libs, however the point is that cited commit is not safe and may touch more ports. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111209154940.GA77124>