Date: Mon, 4 Feb 2008 10:49:15 -0500 (EST) From: Daniel Eischen <deischen@freebsd.org> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: Attilio Rao <attilio@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, threads@freebsd.org Subject: Re: cvs commit: src/include pthread_np.h src/lib/libthr pthread.map src/lib/libthr/thread thr_mutex.c Message-ID: <Pine.GSO.4.64.0802041048330.13743@sea.ntplx.net> In-Reply-To: <868x21gdtm.fsf@ds4.des.no> References: <200802032238.m13McAbf065324@repoman.freebsd.org> <86d4rdgehd.fsf@ds4.des.no> <3bbf2fe10802040318q456556e4g8c63299ab67c71e8@mail.gmail.com> <868x21gdtm.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---559023410-758783491-1202140155=:13743 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 4 Feb 2008, Dag-Erling Sm=C3=B8rgrav wrote: > "Attilio Rao" <attilio@freebsd.org> writes: >> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: >>> I'm having second thoughts about this one. There is a significant >>> risk of false positives if the mutex is currently locked by another >>> thread. I'm wondering whether to a) change the implementation so it >>> only returns true if the mutex is owned by the current thread, or b) >>> change the interface so you can specify a specific thread, or NULL >>> for "any". >> Please don't do the latter. Semantically the right thing to do here >> is to assert if the curthread owns the lock or not. Any lock should >> not be interested on what is the state in regard of other locks. > > Thank you. That was my thought as well, but I didn't want to exclude > the alternative without discussion. Then please change the API so that it is pthread_mutex_isowned_np(). --=20 DE ---559023410-758783491-1202140155=:13743--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.64.0802041048330.13743>