Date: Thu, 20 Oct 2011 23:49:25 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: David Wolfskill <david@catwhisker.org>, current@freebsd.org Subject: Re: sys/conf/newvers.sh vs. subversion-1.7 Message-ID: <CAGH67wRrop1aW=1CXtK3jPbRzdv814pNXOZdUzjjz=EwHhv%2Btg@mail.gmail.com> In-Reply-To: <20111020122121.GL59810@albert.catwhisker.org> References: <20111020114844.GK59810@albert.catwhisker.org> <20111020122121.GL59810@albert.catwhisker.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 20, 2011 at 5:21 AM, David Wolfskill <david@catwhisker.org> wro=
te:
> On Thu, Oct 20, 2011 at 04:48:44AM -0700, David Wolfskill wrote:
>> ...
>> Well, as of subversion-1.7, we don't have a ".svn" directory in
>> ${SYSDIR} any more -- it's only at the root of the working copy
>> (/usr/src, in this case). =A0So "svnversion" is never invoked.
>>
>> So I've just hacked my copy to parallel the "git" stanza & look for
>> ${SYSDIR}/../.svn, =A0Not sure that's ideal, but there appears to be
>> precedent.... :-}
>>
>> It might be handy to resolve this prior to 9.0-RELEASE, I think.
>> ...
>
> Finished building head, and the change worked; here are uname strings
> from yesterday & today:
>
> FreeBSD freebeast.catwhisker.org 10.0-CURRENT FreeBSD 10.0-CURRENT #625: =
Wed Oct 19 05:22:52 PDT 2011 =A0 =A0 root@freebeast.catwhisker.org:/usr/obj=
/usr/src/sys/GENERIC =A0i386
>
> FreeBSD freebeast.catwhisker.org 10.0-CURRENT FreeBSD 10.0-CURRENT #626 r=
226563M: Thu Oct 20 05:04:03 PDT 2011 =A0 =A0 root@freebeast.catwhisker.org=
:/usr/obj/usr/src/sys/GENERIC =A0i386
>
> I've attached a copy of the patch, in case my description wasn't
> clear. =A0And I'll plan on filing a PR a bit later today.
Awesome! Is there any way that this could be committed, as well
incorporate the other two PRs (conf/146828, misc/149510) before
9.0-RELEASE? They all seem to overlap a bit and are helpful for
developers and contributors.
I'll write up a 1 unified patch for the minimal changes
(conf/146828, conf/161835) and revamp the other change if someone
will commit the work.
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wRrop1aW=1CXtK3jPbRzdv814pNXOZdUzjjz=EwHhv%2Btg>