Date: Thu, 01 Dec 2005 15:20:26 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Jean-Yves Lefort <jylefort@freebsd.org> Cc: emulation@freebsd.org Subject: Re: cvs commit: ports/audio/linux-openal bsd.linux.mk Message-ID: <20051201152026.lxwvpjokc0sw0okc@netchild.homeip.net> In-Reply-To: <200511261918.jAQJIp91001719@repoman.freebsd.org> References: <200511261918.jAQJIp91001719@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jean-Yves Lefort <jylefort@FreeBSD.org> wrote:
[moving to emulation@]
I have a backlog of cvs-all mails... I'm slowly catching up and noticed this
one without further looking if someone wrote some comments (but I looked at
rev 1.2 of the file).
> jylefort 2005-11-26 19:18:51 UTC
>
> FreeBSD ports repository
>
> Added files:
> audio/linux-openal bsd.linux.mk
> Log:
> Add my RPM support infrastructure.
^^
Isn't this a little bit selfish? ;-)
Ok, more serious comments (*constructive* critic):
- that's the wrong name for this file, bsd.rpm.mk or
bsd.linuxrpm.mk would be better, since it does not contain
all linux related mk-fu
- install-time generated plists are evil (as per discussion on
ports@ a while ago (and as of very recent experience with the
linux ports), so the pre-install target should be removed and
a real plist should be generated), have a look at the linux-gtk
Makefile for a target which generates an initial plist (needs
to be modified a little bit afterwards)
- it should be installed into PORTSDIR/Mk, so that other port can
use it
- does the ppc have a linuxolator?
- why do you use different ways of specifying the paths in DESCR
and MD5_FILE?
- why do you specify DESCR at all?
- INSTALLS_LINUX_SHLIB should be removed, fix the FreeBSD one
instead to not do anything in the USE_LINUX case and reuse the
name of the FreeBSD one (-> more consistent and easy
description on the porters handbook)
In general it's nice to see someone working on this. And I like the idea to
use rpm2cpio instead of rpm. We could get rid of the rpm-db in the linux
base ports this way (this removes some of those annoying warnings on
pkg_deinstall).
Bye,
Alexander.
--
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Insanity is the final defense. It's hard to get a refund when
the salesman is sniffing your crotch and baying at the moon.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051201152026.lxwvpjokc0sw0okc>