Date: Tue, 01 Oct 2002 12:47:29 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_synch.c Message-ID: <XFMail.20021001124729.jhb@FreeBSD.org> In-Reply-To: <20021002004350.C1540-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01-Oct-2002 Bruce Evans wrote: > On Tue, 1 Oct 2002, John Baldwin wrote: > >> jhb 2002/10/01 07:10:09 PDT >> >> Modified files: >> sys/kern kern_synch.c >> Log: >> - Adjust comment noting that handling of CPU limit exhaustion is done in >> ast(). >> - Actually set KEF_ASTPENDING so ast() is called. I think this is buggy >> for a process with multiple KSE's in that PS_XCPU is not a KSE event, >> it's a process-wide event. IMO there really should probably be two >> ASTPENDING flags, one for per-process, and one for per-KSE. >> >> Submitted by: bde > > I'm not sure who "I" is here :-). I think setting the flag for only one > KSE is kludgy but not buggy. Killing the process from 1 thread is > sufficient. If you killed it from several then you want to avoid warning > and bumping the cpu limit for each kill (the actual kills would coalesce). > One ASTPENDING flag process may already be one too many, since you have > to remember to set it together with the flag(s) that tell ast() what to > do, and having a summary flag like it doesn't significantly simplify the > test for whether ast() should be called. The "I" is me, sorry. I replied to you in a private e-mail that I think we could abolish the actual ASTPENDING flags and instead define those constants as a mask of the relevant flags that should be tested against. > Thanks for committing this and related patches. Thanks for the good bugfixes. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021001124729.jhb>