Date: Mon, 04 Jan 2010 02:59:18 +0100 From: Dimitry Andric <dimitry@andric.com> To: Jilles Tjoelker <jilles@stack.nl> Cc: "E. O." <enginbsd@gmail.com>, freebsd-stable@freebsd.org Subject: Re: locale-related build problems Message-ID: <4B414B76.2060900@andric.com> In-Reply-To: <20100103140303.GA1899@stack.nl> References: <86095ec11001021301i25e91191kdcc2a1673795dce7@mail.gmail.com> <20100103140303.GA1899@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2010-01-03 15:03, Jilles Tjoelker wrote:
> This should be fixed by adding LC_ALL=C somewhere in the build process,
> possibly only for these awk commands.
Here is a quite minimal diff to do so, at least for the buildkernel
part.
In any case, it looks like awk is used quite a lot in other places
during buildworld; some of these invocations already use LC_ALL=C, most
of them do not. There are even invocations of sh using LC_ALL=C. :)
Instead of peppering the whole tree with LC_ALL=C insertions, would it
make sense to simply set LC_ALL=C globally during building world and
kernel? Or are there parts that actually use locales during the build?
Index: sys/conf/kern.pre.mk
===================================================================
--- sys/conf/kern.pre.mk (revision 201193)
+++ sys/conf/kern.pre.mk (working copy)
@@ -14,7 +14,7 @@
M= ${MACHINE_ARCH}
-AWK?= awk
+AWK?= LC_ALL=C awk
LINT?= lint
NM?= nm
OBJCOPY?= objcopy
Index: sys/conf/kmod.mk
===================================================================
--- sys/conf/kmod.mk (revision 201193)
+++ sys/conf/kmod.mk (working copy)
@@ -60,7 +60,7 @@
# Unload a module.
#
-AWK?= awk
+AWK?= LC_ALL=C awk
KMODLOAD?= /sbin/kldload
KMODUNLOAD?= /sbin/kldunload
OBJCOPY?= objcopy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B414B76.2060900>