Date: Tue, 23 Jan 2018 04:09:10 +0700 From: Eugene Grosbein <eugen@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r459676 - in head/sysutils/zfsnap: . files Message-ID: <5A6652F6.4000406@freebsd.org> In-Reply-To: <20180122192531.7xs4zndt6wrh3nbq@atuin.in.mat.cc> References: <201801221705.w0MH5n8N044357@repo.freebsd.org> <20180122172614.ptlibdvjq42myqzp@aragorn.in.absolight.net> <5A662E1F.6010408@freebsd.org> <20180122192531.7xs4zndt6wrh3nbq@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
23.01.2018 2:25, Mathieu Arnold wrote: > On Mon, Jan 22, 2018 at 06:31:59PM +0000, Eugene Grosbein wrote: >> 23.01.2018 0:26, Mathieu Arnold wrote: >> >>> On Mon, Jan 22, 2018 at 05:05:49PM +0000, Eugene Grosbein wrote: >>>> Move creation of files from "do-patch" to "post-extract" target, >>>> so that patches from files/ directory get applied. >>>> >>>> -do-patch: >>>> +post-extract: >>> >>> I am sure you meant to use post-extract here. >> >> And I did. What is a problem here? > > Sorry, meant post-patch here. "post-patch" means we will not be able conditionally patch generated files with extra-patches, for example. As we could not apply simple patch before this change due to abuse of "do-patch". So, "post-extract" is intentional.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5A6652F6.4000406>