Date: Thu, 2 Nov 2017 19:08:50 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: sgk@troutmask.apl.washington.edu Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, freebsd-hackers <freebsd-hackers@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: Head build unsafe for /etc today Message-ID: <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> In-Reply-To: <20171103014907.GA88522@troutmask.apl.washington.edu> References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Nov 2, 2017, at 18:49, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote: > >> On Thu, Nov 02, 2017 at 06:25:24PM -0700, Bryan Drewery wrote: >> >> On Nov 2, 2017, at 15:44, Mark Millard <markmi@dsl-only.net> wrote: >> >>>> Author: bdrewery >>>> Date: Thu Nov 2 22:23:00 2017 >>>> New Revision: 325347 >>>> URL: >>>> https://svnweb.freebsd.org/changeset/base/325347 >>>> >>>> >>>> Log: >>>> Something is very wrong >> >> >> Unfortunately I only test with META_MODE these days which implies -DNO_CLEAN. > > You're making changes to the build infrastructure and you're > not properly testing it before committing? This is beyond > pointyhat material. I ran 2 universes, dozens of buildworlds and buildkernels, dozens of installworld and installkernel, several xdev and native-xtools, several full DIRDEPS_BUILD builds and bootstraps, ran subdir builds, ran subdir cleans, tested several targets together, ran various special case tests for submakes, played around with a ton of MAKEOBJDIRPREFIX cases, handled and tested symlinked objdirs special, ran it through my work repro a few times, did special testing in rescue/, and had a volunteer test release. In the process I found a bmake bug, GPL_DTC build bug and several others I don’t recall from the bus. What I missed was the “clean” buildworld because I forgot it even exists. I’ve wanted to remove it for a year. I also forgot to test buildenv. By the way the bug ran into here was 3-4 years old and I avoided the exact case in some new code but missed that the problem was already existing subtly in bsd.obj.mk. Having said all of that, I certainly don’t do so much testing normally but these changes warranted the time I put in. > > -- > Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68BECDA4-C182-436E-854C-C3B19ABB4373>