Date: Sun, 12 Jul 2020 18:17:15 +0200 From: Alexander Leidinger <Alexander@leidinger.net> To: Dimitry Andric <dim@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r363125 - head/sys/compat/linux Message-ID: <20200712181715.Horde.YfOdq0fEkeFHjcx0fXxQcX1@webmail.leidinger.net> In-Reply-To: <010ACFFA-35B7-4984-A5E7-1504C72D56F9@FreeBSD.org> References: <202007120951.06C9pA4F024281@repo.freebsd.org> <010ACFFA-35B7-4984-A5E7-1504C72D56F9@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Quoting Dimitry Andric <dim@freebsd.org> (from Sun, 12 Jul 2020 15:36:25 +0200): > On 12 Jul 2020, at 11:51, Alexander Leidinger <netchild@freebsd.org> wrote: >> >> Author: netchild >> Date: Sun Jul 12 09:51:09 2020 >> New Revision: 363125 >> URL: https://svnweb.freebsd.org/changeset/base/363125 >> >> Log: >> Implement CLOCK_MONOTONIC_RAW (linux >= 2.6.28). >> >> It is documented as a raw hardware-based clock not subject to NTP or >> incremental adjustments. With this "not as precise as CLOCK_MONOTONIC" >> description in mind, map it to our CLOCK_MONOTNIC_FAST (the same >> mapping as for the linux CLOCK_MONOTONIC_COARSE). > > Okay, but: > >> @@ -212,6 +212,7 @@ linux_to_native_clockid(clockid_t *n, clockid_t l) >> *n = CLOCK_THREAD_CPUTIME_ID; >> break; >> case LINUX_CLOCK_REALTIME_COARSE: >> + case LINUX_CLOCK_MONOTONIC_RAW: >> *n = CLOCK_REALTIME_FAST; >> break; >> case LINUX_CLOCK_MONOTONIC_COARSE: > > this shows it is actually mapped to CLOCK_REALTIME_FAST, not > CLOCK_MONOTONIC_FAST. Is the code right, or the commit message? :) The commit message and the code I have running are right, the code I committed from a "no other change than that"-svn-tree was not. :( I think I should switch to "diff | patch" even for one-liners like that. I commited the fix based upon another message I've seen before this one, but thanks for looking at the code. Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJfCzeLAAoJEBINsJsD+NiGiH0P/jUVckgElq1GHVof81Ns1uAl s8LUcIHt32XgRTNNJKH672y0X0QipVqrpz+iCghdsfF+zgpIzPI6giz+/ZETaqAs en4ypIW1XZhKjVoSzAhvSUv7B6B0HpQoZxi9O3nSpkDeaRdBFsVuoBcoT/DN3AcY Jb2H87Pl1nBVM4inkqyXfA19ALE+ZSuoYrfoQbJBLuV4iSWJLYecV1YE1Fr4SPfi 2t2lmSYBFpQXhVaXSa351thzpSNrRO1LS5axDkmIjORKnDxb9sn+FPkJrXD5RKfT +8MjjQ5kUrYWfqFPhhPclUXN5Dc2pMrELAJi0lfAH7TBBhL7YVP/IbBBvKBbthtn nUEUYGF471VMnD81EAI016d9SYyoqyIjQM0ab53a8EUDsz+r/tt76UC+nyHs2Rmr yqr5MGTB+dvugrAV22sgCrzxoQ5MbwrS+noqZqBrhNlY3s3ZumMdNcHRu50h9MKB WfBSciH/9061RQXxFG7z7qnH9tr8F376ttydytG4Zu5RDVY7tVx5rBdx4/ImFaLK B8IjoJbLSwnLTtCFPexrKT2BGdnGcj7g4kc3/x3LsjWBHpZUeyFEjF7o5kZJPJEG jKsDJMCvxvGvmpnxZeUYV2Nh1V9/gAVTxLI4UVNrF+q/msvxRG/H7h4p/dwwoHLr 2VMzx8GeUgW59sbOapgK =WHPn -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200712181715.Horde.YfOdq0fEkeFHjcx0fXxQcX1>