Date: Fri, 7 Apr 2023 16:50:21 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ca9e112b42fd - main - sysutils/cpu-x: try to further improve the port (part one) Message-ID: <ZDBJzVxkRtMqmoXB@FreeBSD.org> In-Reply-To: <202304071423.337ENhCa014056@gitrepo.freebsd.org> References: <202304071423.337ENhCa014056@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 07, 2023 at 02:23:43PM +0000, Alexey Dokuchaev wrote:
> commit ca9e112b42fdc623acc09e7ec5707249e08fa6ad
>
> - Setting PKGNAMESUFFIX=-${FLAVOR} for all flavors was actually
> misleading: graphic version (GTK+) includes ncurses UI as well,
> so mark the console-only one as such (`tuionly') while keeping
> the full package unsuffixed
>
> @@ -34,6 +32,7 @@ FLAVORS= gtk3 ncurses
> CONFLICTS_INSTALL= ${FLAVORS:N${FLAVOR}:S/^/${PORTNAME}-/}
>
> .if ${FLAVOR:U} == ncurses
> +PKGNAMESUFFIX= -tuionly
You forgot to adjust CONFLICTS_INSTALL above now that PKGNAMEs are
different. Please fix it next time you touch the Makefile.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZDBJzVxkRtMqmoXB>