Date: Sat, 17 Mar 2012 18:10:50 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-projects@FreeBSD.org, Grzegorz Bernacki <gber@FreeBSD.org>, src-committers@FreeBSD.org Subject: Re: svn commit: r233072 - projects/nand/sys/kern Message-ID: <20120317161050.GI75778@deviant.kiev.zoral.com.ua> In-Reply-To: <20120317085116.GC1340@garage.freebsd.pl> References: <201203170318.q2H3ITdI047893@svn.freebsd.org> <20120317085116.GC1340@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--Rrd1FBYt5NX8iyQT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 17, 2012 at 09:51:16AM +0100, Pawel Jakub Dawidek wrote: > On Sat, Mar 17, 2012 at 03:18:29AM +0000, Grzegorz Bernacki wrote: > > Author: gber > > Date: Sat Mar 17 03:18:28 2012 > > New Revision: 233072 > > URL: http://svn.freebsd.org/changeset/base/233072 > >=20 > > Log: > > Add VFS changes necessary for NANDFS to work. > > =20 > > Ignore B_MANAGED buffer by syncer and ignore signal when msleep as it > > can cause file system inconsistency. >=20 > I'd suggest running these changes through kib@. Especially vn_start_write= () > change below looks ugly, but maybe it is only temporary? It is not only ugly (and object against it). If the change makes any difference for the filesystem, then I just argue that the filesystem is broken. The vn_start_write() is done on the VFS entry peripheral, long before filesystem code is hit. I did not looked at the managed changes, you would need to describe=20 what is wrong with current code and what is the purpose of the changes. B_MANAGED came from xfs, it seems, or at least xfs is the only current consumer of B_MANAGED buffers. --Rrd1FBYt5NX8iyQT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk9kt4oACgkQC3+MBN1Mb4imjwCbBfhIB+x7m08MpjbfoQTxO3vB GlIAniz96PXFYEynZ2RDiIkxJaJKvzXO =karN -----END PGP SIGNATURE----- --Rrd1FBYt5NX8iyQT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120317161050.GI75778>