Date: Fri, 04 Apr 2025 21:41:27 +0100 From: "Tom Jones" <thj@freebsd.org> To: "Colin Percival" <cperciva@tarsnap.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 74a6f2a76b32 - main - iwx: Shorten log code field Message-ID: <1db1061f-f8a7-40d8-b9b3-e3a81bdfaebf@app.fastmail.com> In-Reply-To: <01000195fcbbe2ed-0afa2175-1e23-4d89-bda4-5bd86437b3a2-000000@email.amazonses.com> References: <202504030707.53377PCW040790@gitrepo.freebsd.org> <01000195fcbbe2ed-0afa2175-1e23-4d89-bda4-5bd86437b3a2-000000@email.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry for the breakage, something has broken in my mail filters so direct mails to me aren’t landing in my inbox when also sent to src-commits (just the folder for commits).
I’ll look at this as soon as I can (probably not until Monday). If you want to remove iwx from the build (or just i386 in the meantime) please do.
On Thu, Apr 3, 2025, at 18:38, Colin Percival wrote:
> On 4/3/25 00:07, Tom Jones wrote:
>> commit 74a6f2a76b32e01d05c4ad71897bd3a6831e703e
>>
>> This fixes the build on i386.
>
> You sure about that?
>
> /usr/src/sys/dev/iwx/if_iwx.c:5762:22: error: shift count >= width of type
> [-Werror,-Wshift-count-overflow]
> 5762 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
> le32toh(desc->tbs[0].tb_len)) >> 32)
> | ^ ~~
> /usr/src/sys/dev/iwx/if_iwx.c:5762:80: error: shift count >= width of type
> [-Werror,-Wshift-count-overflow]
> 5762 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
> le32toh(desc->tbs[0].tb_len)) >> 32)
> |
> ^ ~~
> /usr/src/sys/dev/iwx/if_iwx.c:5769:22: error: shift count >= width of type
> [-Werror,-Wshift-count-overflow]
> 5769 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
> le32toh(desc->tbs[1].tb_len)) >> 32)
> | ^ ~~
> /usr/src/sys/dev/iwx/if_iwx.c:5769:80: error: shift count >= width of type
> [-Werror,-Wshift-count-overflow]
> 5769 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
> le32toh(desc->tbs[1].tb_len)) >> 32)
> |
> ^ ~~
> /usr/src/sys/dev/iwx/if_iwx.c:5778:23: error: shift count >= width of type
> [-Werror,-Wshift-count-overflow]
> 5778 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
> le32toh(desc->tbs[i + 2].tb_len)) >> 32)
> | ^ ~~
> /usr/src/sys/dev/iwx/if_iwx.c:5778:85: error: shift count >= width of type
> [-Werror,-Wshift-count-overflow]
> 5778 | if (data->cmd_paddr >> 32 != (data->cmd_paddr +
> le32toh(desc->tbs[i + 2].tb_len)) >> 32)
> |
> ^ ~~
> /usr/src/sys/dev/iwx/if_iwx.c:10971:47: error: format specifies type 'unsigned
> long' but the argument has type 'uint64_t' (aka 'unsigned long long')
> [-Werror,-Wformat]
> 10971 | DPRINTF(("%s: k->wk_keytsc=%lu\n", __func__, k->wk_keytsc));
> | ~~~ ^~~~~~~~~~~~
> | %llu
>
> --
> Colin Percival
> FreeBSD Release Engineering Lead & EC2 platform maintainer
> Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
--
- Tom
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1db1061f-f8a7-40d8-b9b3-e3a81bdfaebf>