Date: Wed, 8 Aug 2001 07:30:55 -0700 From: Mark Peek <mark@whistle.com> To: Peter Pentchev <roam@ringlet.net>, Bruce Evans <bde@zeta.org.au> Cc: audit@FreeBSD.ORG Subject: Re: [PATCH] fix a file(1) minor POLA stretching Message-ID: <p0510031fb796f6fd7184@[207.76.207.129]> In-Reply-To: <20010808123139.G534@ringworld.oblivion.bg> References: <p0510030bb795ce34d864@[207.76.207.129]> <20010808183309.M6269-100000@besplex.bde.org> <20010808123139.G534@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
At 12:31 PM +0300 8/8/01, Peter Pentchev wrote:
>On Wed, Aug 08, 2001 at 06:45:44PM +1000, Bruce Evans wrote:
> > Building at install time breaks installing from readonly object trees
> > (if the sources somehow become out of date).
Bruce, thanks for catching my mistake. You're right, my patch would
break readonly object trees.
>True. Then how about just generating the magic DB at install time,
>right into the destination directory?
>Patch attached.
Given the constraints of cross platform builds and readonly object
trees (phase of the moon anyone? :-) ), I believe your updated patch
is on the right track.
> beforeinstall:
> $(INSTALL) $(COPY) -o $(BINOWN) -g $(BINGRP) -m $(MAGICMODE) \
> magic $(DESTDIR)$(MAGICFILE)
>+ cd ${DESTDIR}${MAGICFILE:H} && \
>+ ${.OBJDIR}/file -C -m ${DESTDIR}${MAGICFILE}
>
I don't believe the "cd" is necessary and you could get away with:
./file -C -m ${DESTDIR}${MAGICFILE}
Mark
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0510031fb796f6fd7184>