Date: Wed, 06 Jan 2021 10:02:45 -0700 From: "Brad Davis" <brd@FreeBSD.org> To: "Mateusz Guzik" <mjg@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: =?UTF-8?Q?Re:_git:_deabdc686874_-_main_-_cache:_stop_pre-checking_seqc_w?= =?UTF-8?Q?hen_starting_the_lookup?= Message-ID: <c4525b03-81e8-4b98-8904-2f2143f013f0@www.fastmail.com> In-Reply-To: <202101060736.1067aB81077326@gitrepo.freebsd.org> References: <202101060736.1067aB81077326@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 6, 2021, at 12:36 AM, Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=deabdc686874411bd32775c3bdd04c04d9eff3e5 > > commit deabdc686874411bd32775c3bdd04c04d9eff3e5 > Author: Mateusz Guzik <mjg@FreeBSD.org> > AuthorDate: 2021-01-06 06:12:58 +0000 > Commit: Mateusz Guzik <mjg@FreeBSD.org> > CommitDate: 2021-01-06 07:28:07 +0000 > > cache: stop pre-checking seqc when starting the lookup > > Tested by: pho > --- > sys/kern/vfs_cache.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c > index 710c499d6bb5..138a55f94dbd 100644 > --- a/sys/kern/vfs_cache.c > +++ b/sys/kern/vfs_cache.c > @@ -5032,7 +5032,7 @@ cache_fplookup_skip_slashes(struct cache_fpl *fpl) > ndp->ni_next = cnp->cn_nameptr; > > /* > - * Retry the lookup, similar to dot lookups. > + * See cache_fplookup_dot. > */ > fpl->tvp = fpl->dvp; > fpl->tvp_seqc = fpl->dvp_seqc; > @@ -5139,11 +5139,14 @@ cache_fplookup_impl(struct vnode *dvp, struct > cache_fpl *fpl) > > cache_fpl_checkpoint(fpl, &fpl->snd); > > + /* > + * The vnode is hand is almost always stable, skip checking for it. "The vnode in hand" maybe? Regards, Brad Davis
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c4525b03-81e8-4b98-8904-2f2143f013f0>