Date: Tue, 6 Dec 2022 16:38:39 GMT From: Andrew Gallatin <gallatin@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 17859d538c23 - main - ixl: silence runtime warning when PCI_IOV is not enabled Message-ID: <202212061638.2B6GcddP091465@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=17859d538c23d6faa5a5512262d678377130e591 commit 17859d538c23d6faa5a5512262d678377130e591 Author: Andrew Gallatin <gallatin@FreeBSD.org> AuthorDate: 2022-12-06 16:35:18 +0000 Commit: Andrew Gallatin <gallatin@FreeBSD.org> CommitDate: 2022-12-06 16:35:18 +0000 ixl: silence runtime warning when PCI_IOV is not enabled When PCI_IOV is not enabled, do not attempt to call iflib_softirq_alloc_generic(...IFLIB_INTR_IOV), as it results in boot-time warnings similar to: taskqgroup_attach_cpu: qid not found for iov cpu=2 ixl2: taskqgroup_attach_cpu failed 22 Instead, make it conditional on PCI_IOV like the other SR-IOV related code. Reviewed by: erj Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D37609 --- sys/dev/ixl/if_ixl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/ixl/if_ixl.c b/sys/dev/ixl/if_ixl.c index cb3ce72a95ed..352a35d95512 100644 --- a/sys/dev/ixl/if_ixl.c +++ b/sys/dev/ixl/if_ixl.c @@ -1064,8 +1064,11 @@ ixl_if_msix_intr_assign(if_ctx_t ctx, int msix) "Failed to register Admin Que handler"); return (err); } + +#ifdef PCI_IOV /* Create soft IRQ for handling VFLRs */ iflib_softirq_alloc_generic(ctx, NULL, IFLIB_INTR_IOV, pf, 0, "iov"); +#endif /* Now set up the stations */ for (i = 0, vector = 1; i < vsi->shared->isc_nrxqsets; i++, vector++, rx_que++) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202212061638.2B6GcddP091465>