Date: Wed, 15 Jan 2020 13:32:55 -0700 From: Warner Losh <imp@bsdimp.com> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: Oliver Pinter <oliver.pntr@gmail.com>, Ben Woods <woodsb02@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Ed Maste <emaste@freebsd.org> Subject: Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts Message-ID: <CANCZdfpOw54MQsW4aohLn3ufgEqK8beTe_EdjYktViFubPPyzg@mail.gmail.com> In-Reply-To: <ed0b16af-01c8-62fe-918a-3f1f9f9dcbd8@freebsd.org> References: <202001150747.00F7lqiG071097@repo.freebsd.org> <CAPjTQNHa9Um%2B0S8zMD3eeop3YSdVti0o=DSv5%2BB=455wcrq3VA@mail.gmail.com> <ed0b16af-01c8-62fe-918a-3f1f9f9dcbd8@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 15, 2020 at 12:10 PM Nathan Whitehorn <nwhitehorn@freebsd.org> wrote: > I agree -- this seems like a really big change, especially with no > discussion. > I agree this is the right thing to do. ZFS is the best fit for most people (there are exceptions, and they can install UFS and if ZFS isn't right for you, you're likely well aware of it[*]). ZFS is a huge asset to FreeBSD, and we should lead with strength. And the UFS option is there for people that don't want ZFS. Nothing changes there... In an ideal world, it likely should have been socialized first on arch@ (it's likely still good to chat about it there). It would likely be good to kick off a discussion there, but honestly, this should be a fairly boring, bland change for most people in our core, target market. There's little compelling reason to not use ZFS, unless your work load hits the fairly narrow range where ZFS isn't so good. Warner [*] Netflix uses UFS because of sendfile efficiencies, but we don't use the installer to install our systems: we have our own custom one our system integrators use since it has a lot of extra specific checks we need, but that aren't relevant to others. And my personal systems are almost all ZFS (the ones that aren't date from a time that ZFS wasn't in the system, or too new for me to trust it). > -Nathan > > On 2020-01-15 10:57, Oliver Pinter wrote: > > > > > > On Wednesday, January 15, 2020, Ben Woods <woodsb02@freebsd.org > > <mailto:woodsb02@freebsd.org>> wrote: > > > > Author: woodsb02 (ports committer) > > Date: Wed Jan 15 07:47:52 2020 > > New Revision: 356758 > > URL: https://svnweb.freebsd.org/changeset/base/356758 > > <https://svnweb.freebsd.org/changeset/base/356758>; > > > > Log: > > bsdinstall: Change "default" (first) Partitioning method to ZFS > > > > Reported by: Ruben Schade (during his talk at linux.conf.au > > <http://linux.conf.au>) > > Approved by: philip > > Differential Revision: https://reviews.freebsd.org/D23173 > > <https://reviews.freebsd.org/D23173>; > > > > > > What's the justification behind this change? > > Plus I miss from here the relontes tag. > > > > > > > > > > Modified: > > head/usr.sbin/bsdinstall/bsdinstall.8 > > head/usr.sbin/bsdinstall/scripts/auto > > > > Modified: head/usr.sbin/bsdinstall/bsdinstall.8 > > > ============================================================================== > > --- head/usr.sbin/bsdinstall/bsdinstall.8 Wed Jan 15 > > 06:18:32 2020 (r356757) > > +++ head/usr.sbin/bsdinstall/bsdinstall.8 Wed Jan 15 > > 07:47:52 2020 (r356758) > > @@ -119,7 +119,7 @@ Provides the installer's interactive guided > > disk parti > > installations. > > Defaults to UFS. > > .It Cm zfsboot > > -Provides an alternative ZFS-only automatic interactive disk > > partitioner. > > +Provides a ZFS-only automatic interactive disk partitioner. > > Creates a single > > .Ic zpool > > with separate datasets for > > > > Modified: head/usr.sbin/bsdinstall/scripts/auto > > > ============================================================================== > > --- head/usr.sbin/bsdinstall/scripts/auto Wed Jan 15 > > 06:18:32 2020 (r356757) > > +++ head/usr.sbin/bsdinstall/scripts/auto Wed Jan 15 > > 07:47:52 2020 (r356758) > > @@ -289,7 +289,7 @@ Shell \"Open a shell and partition by hand\"" > > CURARCH=$( uname -m ) > > case $CURARCH in > > amd64|arm64|i386) # Booting ZFS Supported > > - PMODES="$PMODES \"Auto (ZFS)\" \"Guided > Root-on-ZFS\"" > > + PMODES="\"Auto (ZFS)\" \"Guided Root-on-ZFS\" > $PMODES" > > ;; > > *) # Booting ZFS Unspported > > ;; > > @@ -303,6 +303,10 @@ PARTMODE=`echo $PMODES | xargs dialog > > --backtitle "Fre > > exec 3>&- > > > > case "$PARTMODE" in > > +"Auto (ZFS)") # ZFS > > + bsdinstall zfsboot || error "ZFS setup failed" > > + bsdinstall mount || error "Failed to mount filesystem" > > + ;; > > "Auto (UFS)") # Guided > > bsdinstall autopart || error "Partitioning error" > > bsdinstall mount || error "Failed to mount filesystem" > > @@ -319,10 +323,6 @@ case "$PARTMODE" in > > else > > bsdinstall partedit || error "Partitioning error" > > fi > > - bsdinstall mount || error "Failed to mount filesystem" > > - ;; > > -"Auto (ZFS)") # ZFS > > - bsdinstall zfsboot || error "ZFS setup failed" > > bsdinstall mount || error "Failed to mount filesystem" > > ;; > > *) > > _______________________________________________ > > svn-src-head@freebsd.org <mailto:svn-src-head@freebsd.org> mailing > > list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > <https://lists.freebsd.org/mailman/listinfo/svn-src-head>; > > To unsubscribe, send any mail to > > "svn-src-head-unsubscribe@freebsd.org > > <mailto:svn-src-head-unsubscribe@freebsd.org>" > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpOw54MQsW4aohLn3ufgEqK8beTe_EdjYktViFubPPyzg>