Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Nov 2024 03:25:50 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Max Brazhnikov <makc@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 61a70ba8b94b - main - graphics/libheif: update to 1.19.1
Message-ID:  <CAMHz58R0%2BK7cSkGg6opNzcEVWYh7pR0zyw%2BKZ5yX9Rj3q-g1ew@mail.gmail.com>
In-Reply-To: <202411022034.4A2KYVxk044408@gitrepo.freebsd.org>
References:  <202411022034.4A2KYVxk044408@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000e7cb8906260724d9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Sun, Nov 3, 2024 at 4:34=E2=80=AFAM Max Brazhnikov <makc@freebsd.org> wr=
ote:

> The branch main has been updated by makc:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=3D61a70ba8b94be3288962a5827de15=
6f7777f07e9
>
> commit 61a70ba8b94be3288962a5827de156f7777f07e9
> Author:     Max Brazhnikov <makc@FreeBSD.org>
> AuthorDate: 2024-11-02 20:34:10 +0000
> Commit:     Max Brazhnikov <makc@FreeBSD.org>
> CommitDate: 2024-11-02 20:34:10 +0000
>
>     graphics/libheif: update to 1.19.1
>

It breaks graphics/py-pillow-heif. Would you please provide a fix for this?
Thanks.


>     Drop stale patch.
>     Add new options and enable them by default:
>      - OPENH264 for AVC decoding,
>      - OPENJPH for HT-J2K encoding.
>
>     Release notes:
> https://github.com/strukturag/libheif/releases/tag/v1.19.0
>
> https://github.com/strukturag/libheif/releases/tag/v1.19.1
> ---
>  graphics/libheif/Makefile                   | 23 +++++++++++++++++------
>  graphics/libheif/distinfo                   |  6 +++---
>  graphics/libheif/files/patch-CMakeLists.txt | 10 ----------
>  graphics/libheif/pkg-plist                  |  1 +
>  4 files changed, 21 insertions(+), 19 deletions(-)
>
> diff --git a/graphics/libheif/Makefile b/graphics/libheif/Makefile
> index 5cda6f3254ec..7bd812b0b51d 100644
> --- a/graphics/libheif/Makefile
> +++ b/graphics/libheif/Makefile
> @@ -1,6 +1,5 @@
>  PORTNAME=3D      libheif
> -DISTVERSION=3D   1.18.2
> -PORTREVISION=3D  1
> +DISTVERSION=3D   1.19.1
>  CATEGORIES=3D    graphics
>  MASTER_SITES=3D
> https://github.com/strukturag/${PORTNAME}/releases/download/v${DISTVERSIO=
N}/
>
> @@ -21,18 +20,24 @@ USE_LDCONFIG=3D       yes
>  PLIST_SUB=3D     LIB_VER=3D${DISTVERSION}
>
>  CMAKE_OFF=3D     BUILD_TESTING \
> -               WITH_KVAZAAR
> +               WITH_KVAZAAR \
> +               WITH_UVG266 \
> +               WITH_VVDEC \
> +               WITH_VVENC \
> +               CMAKE_COMPILE_WARNING_AS_ERROR
>  CMAKE_ON=3D      CMAKE_DISABLE_FIND_PACKAGE_Doxygen
>
> -OPTIONS_DEFINE=3D        AOM DAV1D EXAMPLES FFMPEG JPEG LIBDE265 \
> -               OPENJPEG SVTAV1 RAV1E X265
> -OPTIONS_DEFAULT=3DAOM DAV1D FFMPEG JPEG OPENJPEG SVTAV1 X265
> +OPTIONS_DEFINE=3D        AOM DAV1D EXAMPLES FFMPEG JPEG LIBDE265 OPENH26=
4 \
> +               OPENJPEG OPENJPH SVTAV1 RAV1E X265
> +OPTIONS_DEFAULT=3DAOM DAV1D FFMPEG JPEG OPENH264 OPENJPEG OPENJPH SVTAV1
> X265
>  OPTIONS_SUB=3D   yes
>
>  AOM_DESC=3D              AV1 encoding/decoding via libaom
>  FFMPEG_DESC=3D           Use FFmpeg (support for HEVC decoding)
>  DAV1D_DESC=3D            Build dav1e decoder
>  LIBDE265_DESC=3D         Use libde265 (support for HEVC decoding)
> +OPENH264_DESC=3D         AVC decoding via OpenH264
> +OPENJPH_DESC=3D          HT-J2K encoding via OpenJPH
>  SVTAV1_DESC=3D           Build svt-av1 encoder
>  RAV1E_DESC=3D            Build rav1e encoder
>  X265_DESC=3D             Use x265 (support for HEVC encoding)
> @@ -57,9 +62,15 @@ JPEG_CMAKE_BOOL=3D     WITH_JPEG_ENCODER WITH_JPEG_DEC=
ODER
>  LIBDE265_LIB_DEPENDS=3D  libde265.so:multimedia/libde265
>  LIBDE265_CMAKE_BOOL=3D   WITH_LIBDE265
>
> +OPENH264_LIB_DEPENDS=3D  libopenh264.so:multimedia/openh264
> +OPENH264_CMAKE_BOOL=3D   WITH_OpenH264_DECODER
> +
>  OPENJPEG_LIB_DEPENDS=3D  libopenjp2.so:graphics/openjpeg
>  OPENJPEG_CMAKE_BOOL=3D   WITH_OpenJPEG_ENCODER WITH_OpenJPEG_DECODER
>
> +OPENJPH_LIB_DEPENDS=3D   libopenjph.so:graphics/openjph
> +OPENJPH_CMAKE_BOOL=3D    WITH_OPENJPH_ENCODER WITH_OPENJPH_DECODER
> +
>  SVTAV1_LIB_DEPENDS=3D    libSvtAv1Enc.so:multimedia/svt-av1
>  SVTAV1_CMAKE_BOOL=3D     WITH_SvtEnc
>
> diff --git a/graphics/libheif/distinfo b/graphics/libheif/distinfo
> index 9357a480d72a..dcfeae3ad8fc 100644
> --- a/graphics/libheif/distinfo
> +++ b/graphics/libheif/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP =3D 1724245714
> -SHA256 (libheif-1.18.2.tar.gz) =3D
> c4002a622bec9f519f29d84bfdc6024e33fd67953a5fb4dc2c2f11f67d5e45bf
> -SIZE (libheif-1.18.2.tar.gz) =3D 1525096
> +TIMESTAMP =3D 1730562330
> +SHA256 (libheif-1.19.1.tar.gz) =3D
> 994913eb2a29c00c146d6f3d61e07d9ff0d8e9eccb0624d87e4be8b108c74e4b
> +SIZE (libheif-1.19.1.tar.gz) =3D 1649119
> diff --git a/graphics/libheif/files/patch-CMakeLists.txt
> b/graphics/libheif/files/patch-CMakeLists.txt
> deleted file mode 100644
> index fed1d8aeefde..000000000000
> --- a/graphics/libheif/files/patch-CMakeLists.txt
> +++ /dev/null
> @@ -1,10 +0,0 @@
> ---- CMakeLists.txt.orig        2022-11-15 13:24:59 UTC
> -+++ CMakeLists.txt
> -@@ -22,7 +22,6 @@ endif()
> -
> - if(NOT MSVC)
> -   add_definitions(-Wall)
> --  add_definitions(-Werror)
> -   add_definitions(-Wsign-compare)
> -   add_definitions(-Wconversion)
> -   add_definitions(-Wno-sign-conversion)
> diff --git a/graphics/libheif/pkg-plist b/graphics/libheif/pkg-plist
> index c7bf3204831a..0df90c604400 100644
> --- a/graphics/libheif/pkg-plist
> +++ b/graphics/libheif/pkg-plist
> @@ -20,6 +20,7 @@ lib/libheif.so.%%LIB_VER%%
>  %%OPENJPEG%%lib/libheif/libheif-j2kdec.so
>  %%OPENJPEG%%lib/libheif/libheif-j2kenc.so
>  %%RAV1E%%lib/libheif/libheif-rav1e.so
> +%%OPENJPH%%lib/libheif/libheif-jphenc.so
>  %%SVTAV1%%lib/libheif/libheif-svtenc.so
>  libdata/pkgconfig/libheif.pc
>  %%PORTEXAMPLES%%share/man/man1/heif-dec.1.gz
>
>

--000000000000e7cb8906260724d9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hello,=C2=A0</div><div><br></div><div dir=3D"ltr">On =
Sun, Nov 3, 2024 at 4:34=E2=80=AFAM Max Brazhnikov &lt;<a href=3D"mailto:ma=
kc@freebsd.org">makc@freebsd.org</a>&gt; wrote:</div><div class=3D"gmail_qu=
ote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has =
been updated by makc:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D61a70ba8b94be32=
88962a5827de156f7777f07e9" rel=3D"noreferrer" target=3D"_blank">https://cgi=
t.FreeBSD.org/ports/commit/?id=3D61a70ba8b94be3288962a5827de156f7777f07e9</=
a><br>
<br>
commit 61a70ba8b94be3288962a5827de156f7777f07e9<br>
Author:=C2=A0 =C2=A0 =C2=A0Max Brazhnikov &lt;makc@FreeBSD.org&gt;<br>
AuthorDate: 2024-11-02 20:34:10 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Max Brazhnikov &lt;makc@FreeBSD.org&gt;<br>
CommitDate: 2024-11-02 20:34:10 +0000<br>
<br>
=C2=A0 =C2=A0 graphics/libheif: update to 1.19.1<br></blockquote><div><br><=
/div><div>It breaks=C2=A0graphics/py-pillow-heif. Would you please provide =
a fix for this?</div><div>Thanks.</div><div><br></div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">
<br>
=C2=A0 =C2=A0 Drop stale patch.<br>
=C2=A0 =C2=A0 Add new options and enable them by default:<br>
=C2=A0 =C2=A0 =C2=A0- OPENH264 for AVC decoding,<br>
=C2=A0 =C2=A0 =C2=A0- OPENJPH for HT-J2K encoding.<br>
<br>
=C2=A0 =C2=A0 Release notes: <a href=3D"https://github.com/strukturag/libhe=
if/releases/tag/v1.19.0" rel=3D"noreferrer" target=3D"_blank">https://githu=
b.com/strukturag/libheif/releases/tag/v1.19.0</a><br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a hre=
f=3D"https://github.com/strukturag/libheif/releases/tag/v1.19.1" rel=3D"nor=
eferrer" target=3D"_blank">https://github.com/strukturag/libheif/releases/t=
ag/v1.19.1</a><br>
---<br>
=C2=A0graphics/libheif/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0| 23 +++++++++++++++++------<br>
=C2=A0graphics/libheif/distinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +++---<br>
=C2=A0graphics/libheif/files/patch-CMakeLists.txt | 10 ----------<br>
=C2=A0graphics/libheif/pkg-plist=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 1 +<br>
=C2=A04 files changed, 21 insertions(+), 19 deletions(-)<br>
<br>
diff --git a/graphics/libheif/Makefile b/graphics/libheif/Makefile<br>
index 5cda6f3254ec..7bd812b0b51d 100644<br>
--- a/graphics/libheif/Makefile<br>
+++ b/graphics/libheif/Makefile<br>
@@ -1,6 +1,5 @@<br>
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 libheif<br>
-DISTVERSION=3D=C2=A0 =C2=A01.18.2<br>
-PORTREVISION=3D=C2=A0 1<br>
+DISTVERSION=3D=C2=A0 =C2=A01.19.1<br>
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 graphics<br>
=C2=A0MASTER_SITES=3D=C2=A0 <a href=3D"https://github.com/strukturag/$%7BPO=
RTNAME%7D/releases/download/v$%7BDISTVERSION%7D/" rel=3D"noreferrer" target=
=3D"_blank">https://github.com/strukturag/${PORTNAME}/releases/download/v${=
DISTVERSION}/</a><br>
<br>
@@ -21,18 +20,24 @@ USE_LDCONFIG=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0yes<br>
=C2=A0PLIST_SUB=3D=C2=A0 =C2=A0 =C2=A0LIB_VER=3D${DISTVERSION}<br>
<br>
=C2=A0CMAKE_OFF=3D=C2=A0 =C2=A0 =C2=A0BUILD_TESTING \<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WITH_KVAZAAR<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WITH_KVAZAAR \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WITH_UVG266 \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WITH_VVDEC \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WITH_VVENC \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CMAKE_COMPILE_WARNI=
NG_AS_ERROR<br>
=C2=A0CMAKE_ON=3D=C2=A0 =C2=A0 =C2=A0 CMAKE_DISABLE_FIND_PACKAGE_Doxygen<br=
>
<br>
-OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 AOM DAV1D EXAMPLES FFMPEG JPE=
G LIBDE265 \<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0OPENJPEG SVTAV1 RAV=
1E X265<br>
-OPTIONS_DEFAULT=3DAOM DAV1D FFMPEG JPEG OPENJPEG SVTAV1 X265<br>
+OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 AOM DAV1D EXAMPLES FFMPEG JPE=
G LIBDE265 OPENH264 \<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0OPENJPEG OPENJPH SV=
TAV1 RAV1E X265<br>
+OPTIONS_DEFAULT=3DAOM DAV1D FFMPEG JPEG OPENH264 OPENJPEG OPENJPH SVTAV1 X=
265<br>
=C2=A0OPTIONS_SUB=3D=C2=A0 =C2=A0yes<br>
<br>
=C2=A0AOM_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 AV1 encod=
ing/decoding via libaom<br>
=C2=A0FFMPEG_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Use FFmpeg (su=
pport for HEVC decoding)<br>
=C2=A0DAV1D_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Build dav1e de=
coder<br>
=C2=A0LIBDE265_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Use libde265 (suppo=
rt for HEVC decoding)<br>
+OPENH264_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AVC decoding via OpenH26=
4<br>
+OPENJPH_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 HT-J2K encoding via Open=
JPH<br>
=C2=A0SVTAV1_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Build svt-av1 =
encoder<br>
=C2=A0RAV1E_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Build rav1e en=
coder<br>
=C2=A0X265_DESC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Use x265 =
(support for HEVC encoding)<br>
@@ -57,9 +62,15 @@ JPEG_CMAKE_BOOL=3D=C2=A0 =C2=A0 =C2=A0WITH_JPEG_ENCODER =
WITH_JPEG_DECODER<br>
=C2=A0LIBDE265_LIB_DEPENDS=3D=C2=A0 libde265.so:multimedia/libde265<br>
=C2=A0LIBDE265_CMAKE_BOOL=3D=C2=A0 =C2=A0WITH_LIBDE265<br>
<br>
+OPENH264_LIB_DEPENDS=3D=C2=A0 libopenh264.so:multimedia/openh264<br>
+OPENH264_CMAKE_BOOL=3D=C2=A0 =C2=A0WITH_OpenH264_DECODER<br>
+<br>
=C2=A0OPENJPEG_LIB_DEPENDS=3D=C2=A0 libopenjp2.so:graphics/openjpeg<br>
=C2=A0OPENJPEG_CMAKE_BOOL=3D=C2=A0 =C2=A0WITH_OpenJPEG_ENCODER WITH_OpenJPE=
G_DECODER<br>
<br>
+OPENJPH_LIB_DEPENDS=3D=C2=A0 =C2=A0libopenjph.so:graphics/openjph<br>
+OPENJPH_CMAKE_BOOL=3D=C2=A0 =C2=A0 WITH_OPENJPH_ENCODER WITH_OPENJPH_DECOD=
ER<br>
+<br>
=C2=A0SVTAV1_LIB_DEPENDS=3D=C2=A0 =C2=A0 libSvtAv1Enc.so:multimedia/svt-av1=
<br>
=C2=A0SVTAV1_CMAKE_BOOL=3D=C2=A0 =C2=A0 =C2=A0WITH_SvtEnc<br>
<br>
diff --git a/graphics/libheif/distinfo b/graphics/libheif/distinfo<br>
index 9357a480d72a..dcfeae3ad8fc 100644<br>
--- a/graphics/libheif/distinfo<br>
+++ b/graphics/libheif/distinfo<br>
@@ -1,3 +1,3 @@<br>
-TIMESTAMP =3D 1724245714<br>
-SHA256 (libheif-1.18.2.tar.gz) =3D c4002a622bec9f519f29d84bfdc6024e33fd679=
53a5fb4dc2c2f11f67d5e45bf<br>
-SIZE (libheif-1.18.2.tar.gz) =3D 1525096<br>
+TIMESTAMP =3D 1730562330<br>
+SHA256 (libheif-1.19.1.tar.gz) =3D 994913eb2a29c00c146d6f3d61e07d9ff0d8e9e=
ccb0624d87e4be8b108c74e4b<br>
+SIZE (libheif-1.19.1.tar.gz) =3D 1649119<br>
diff --git a/graphics/libheif/files/patch-CMakeLists.txt b/graphics/libheif=
/files/patch-CMakeLists.txt<br>
deleted file mode 100644<br>
index fed1d8aeefde..000000000000<br>
--- a/graphics/libheif/files/patch-CMakeLists.txt<br>
+++ /dev/null<br>
@@ -1,10 +0,0 @@<br>
---- CMakeLists.txt.orig=C2=A0 =C2=A0 =C2=A0 =C2=A0 2022-11-15 13:24:59 UTC=
<br>
-+++ CMakeLists.txt<br>
-@@ -22,7 +22,6 @@ endif()<br>
- <br>
- if(NOT MSVC)<br>
-=C2=A0 =C2=A0add_definitions(-Wall)<br>
--=C2=A0 add_definitions(-Werror)<br>
-=C2=A0 =C2=A0add_definitions(-Wsign-compare)<br>
-=C2=A0 =C2=A0add_definitions(-Wconversion)<br>
-=C2=A0 =C2=A0add_definitions(-Wno-sign-conversion)<br>
diff --git a/graphics/libheif/pkg-plist b/graphics/libheif/pkg-plist<br>
index c7bf3204831a..0df90c604400 100644<br>
--- a/graphics/libheif/pkg-plist<br>
+++ b/graphics/libheif/pkg-plist<br>
@@ -20,6 +20,7 @@ lib/libheif.so.%%LIB_VER%%<br>
=C2=A0%%OPENJPEG%%lib/libheif/libheif-j2kdec.so<br>
=C2=A0%%OPENJPEG%%lib/libheif/libheif-j2kenc.so<br>
=C2=A0%%RAV1E%%lib/libheif/libheif-rav1e.so<br>
+%%OPENJPH%%lib/libheif/libheif-jphenc.so<br>
=C2=A0%%SVTAV1%%lib/libheif/libheif-svtenc.so<br>
=C2=A0libdata/pkgconfig/libheif.pc<br>
=C2=A0%%PORTEXAMPLES%%share/man/man1/heif-dec.1.gz<br>
<br>
</blockquote></div></div>

--000000000000e7cb8906260724d9--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58R0%2BK7cSkGg6opNzcEVWYh7pR0zyw%2BKZ5yX9Rj3q-g1ew>