Date: Fri, 5 Apr 2019 09:59:57 -0400 From: Ed Maste <emaste@freebsd.org> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs Message-ID: <CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_%2BPUddi43hjp5oKpZP56w@mail.gmail.com> In-Reply-To: <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
>
> > +static const u_char dot_name[] = {
> > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > +static const u_char dotdot_name[] = {
> > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > +
>
> Does it make since to encode these as hex or octal constants,
> one can not tell that those are different values in an easy
> manner. They all look like '.' in the diff, and probably
> in most editors.
They are all either '.' or ' ', the commas are just list separators.
IMO spaces after the commas would make it slightly easier to see.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2C3KXTB7EKnp1PJigjUXY3xB_%2BPUddi43hjp5oKpZP56w>