Date: Fri, 07 Mar 2014 14:46:36 +0100 From: Koop Mast <kwm@rainbow-runner.nl> To: Tijl Coosemans <tijl@FreeBSD.org>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Koop Mast <kwm@FreeBSD.org>, x11@FreeBSD.org Subject: Re: svn commit: r342587 - head/x11/pixman Message-ID: <5319CDBC.50102@rainbow-runner.nl> In-Reply-To: <20140307144458.6634ca47@kalimero.tijl.coosemans.org> References: <201402041839.s14IdgAF097754@svn.freebsd.org> <20140204210959.044bc79a@kalimero.tijl.coosemans.org> <20140205121525.GB24764@FreeBSD.org> <20140304170740.GA82945@FreeBSD.org> <20140307144458.6634ca47@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7-3-2014 14:44, Tijl Coosemans wrote:
> On Tue, 4 Mar 2014 17:07:40 +0000 Alexey Dokuchaev wrote:
>> On Wed, Feb 05, 2014 at 12:15:25PM +0000, Alexey Dokuchaev wrote:
>>> On Tue, Feb 04, 2014 at 09:09:59PM +0100, Tijl Coosemans wrote:
>>>> The is a bit strange because if you turn off SIMD you still get MMX and
>>>> SSE2 support if your cpu supports it. It should be something like this:
>>>>
>>>> .if ! ${PORT_OPTIONS:MSIMD}
>>>> CONFIGURE_ARGS= --disable-vmx --disable-arm-simd --disable-mmx \
>>>> --disable-sse2
>>>> .endif
>>>>
>>>> But then you're still missing --disable-ssse3 and a number of ARM and
>>>> MIPS SIMD options (reported by ./configure --help).
>>>>
>>>> I think it's best to just remove this whole block together with the
>>>> SIMD option because pixman tests at runtime what features the cpu
>>>> supports so in my opinion there's no reason to disable SIMD support.
>>> +1. I've always had to read inside the Makefile to understand what does
>>> this option do; it's very confusing up-front. Please remove it and/or
>>> hide the logic behind the trunk, so it DTRT without annoying users with
>>> cryptic dialogs.
>> Do we have any consensus on this one now? Can we just remove the whole
>> SIMD logic from the Makefile?
> If nobody can come up with a reason to keep it, I'd say remove it.
It will be removed. We planning to update some X ports and will tackle
pixman too.
-Koop
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5319CDBC.50102>