Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Sep 2025 05:59:24 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Christos Margiolis <christos@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 9cab9fde5eda - main - virtual_oss: Port to base
Message-ID:  <20250929125925.0816B8AF@slippy.cwsent.com>
In-Reply-To: <202509280958.58S9wrww083342@gitrepo.freebsd.org>
References:  <202509280958.58S9wrww083342@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <202509280958.58S9wrww083342@gitrepo.freebsd.org>, Christos 
Margioli
s writes:
> The branch main has been updated by christos:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=9cab9fde5edad9b409dd2317a2aec781
> 5e6d6bed
>
> commit 9cab9fde5edad9b409dd2317a2aec7815e6d6bed
> Author:     Christos Margiolis <christos@FreeBSD.org>
> AuthorDate: 2025-09-28 09:56:52 +0000
> Commit:     Christos Margiolis <christos@FreeBSD.org>
> CommitDate: 2025-09-28 09:56:52 +0000
>
>     virtual_oss: Port to base
>     
>     This patch diverges quite a bit from the current upstream [1] in a few
>     ways:
>     
>     1. virtual_oss(8), virtual_bt_speaker(8) and virtual_oss_cmd(8) are
>        actually separate programs.
>     2. Backends (lib/virtual_oss) are built as separate shared libraries and
>        we dlopen() them in virtual_oss(8) and virtual_bt_speaker(8) on
>        demand.
>     3. virtual_equalizer(8) and the sndio and bluetooth backends are built
>        as ports, because they depend on third-party libraries.
>     4. Use newer libav API in bluetooth backend (see HAVE_LIBAV ifdefs) to
>        address compiler errors.
>     
>     [1] https://github.com/freebsd/virtual_oss
>     
>     Sponsored by:   The FreeBSD Foundation
>     MFC after:      1 week
>     Reviewed by:    emaste
>     Differential Revision:  https://reviews.freebsd.org/D52308
> ---
>  etc/mtree/BSD.lib32.dist                           |    2 +
>  etc/mtree/BSD.usr.dist                             |    2 +
>  lib/Makefile                                       |    4 +-
>  lib/virtual_oss/Makefile                           |    9 +
>  lib/virtual_oss/Makefile.inc                       |    3 +
>  lib/virtual_oss/bt/Makefile                        |   19 +
>  lib/virtual_oss/bt/avdtp.c                         |  720 ++++++
>  lib/virtual_oss/bt/avdtp_signal.h                  |  139 ++
>  lib/virtual_oss/bt/bt.c                            | 1061 ++++++++
>  lib/virtual_oss/bt/bt.h                            |  116 +
>  lib/virtual_oss/bt/cosdata-gen/Makefile            |   12 +
>  lib/virtual_oss/bt/cosdata-gen/cosdata.c           |  177 ++
>  lib/virtual_oss/bt/sbc_coeffs.h                    |   69 +
>  lib/virtual_oss/bt/sbc_encode.c                    |  701 ++++++
>  lib/virtual_oss/bt/sbc_encode.h                    |   82 +
>  lib/virtual_oss/null/Makefile                      |   10 +
>  lib/virtual_oss/null/null.c                        |  102 +
>  lib/virtual_oss/oss/Makefile                       |   10 +
>  lib/virtual_oss/oss/oss.c                          |  197 ++
>  lib/virtual_oss/sndio/Makefile                     |   12 +
>  lib/virtual_oss/sndio/sndio.c                      |  203 ++
>  libexec/rc/rc.d/Makefile                           |    1 +
>  libexec/rc/rc.d/virtual_oss                        |  119 +
>  usr.sbin/Makefile                                  |    1 +
>  usr.sbin/virtual_oss/Makefile                      |    8 +
>  usr.sbin/virtual_oss/Makefile.inc                  |    1 +
>  usr.sbin/virtual_oss/virtual_bt_speaker/Makefile   |   11 +
>  .../virtual_oss/virtual_bt_speaker/bt_speaker.c    |  542 ++++
>  .../virtual_bt_speaker/virtual_bt_speaker.8        |   71 +
>  usr.sbin/virtual_oss/virtual_equalizer/Makefile    |   11 +
>  usr.sbin/virtual_oss/virtual_equalizer/equalizer.c |  431 ++++
>  .../virtual_equalizer/virtual_equalizer.8          |  127 +
>  usr.sbin/virtual_oss/virtual_oss/Makefile          |   24 +
>  usr.sbin/virtual_oss/virtual_oss/audio_delay.c     |  238 ++
>  usr.sbin/virtual_oss/virtual_oss/backend.h         |   53 +
>  usr.sbin/virtual_oss/virtual_oss/compressor.c      |   76 +
>  usr.sbin/virtual_oss/virtual_oss/ctl.c             |  615 +++++
>  usr.sbin/virtual_oss/virtual_oss/eq.c              |  226 ++
>  usr.sbin/virtual_oss/virtual_oss/format.c          |  429 ++++
>  usr.sbin/virtual_oss/virtual_oss/httpd.c           |  844 +++++++
>  usr.sbin/virtual_oss/virtual_oss/int.h             |  327 +++
>  usr.sbin/virtual_oss/virtual_oss/main.c            | 2625 ++++++++++++++++++
> ++
>  usr.sbin/virtual_oss/virtual_oss/mul.c             |  175 ++
>  usr.sbin/virtual_oss/virtual_oss/ring.c            |  213 ++
>  usr.sbin/virtual_oss/virtual_oss/utils.h           |   31 +
>  usr.sbin/virtual_oss/virtual_oss/virtual_oss.8     |  355 +++
>  usr.sbin/virtual_oss/virtual_oss/virtual_oss.c     |  914 +++++++
>  usr.sbin/virtual_oss/virtual_oss/virtual_oss.h     |  206 ++
>  usr.sbin/virtual_oss/virtual_oss_cmd/Makefile      |    8 +
>  usr.sbin/virtual_oss/virtual_oss_cmd/command.c     |  113 +
>  .../virtual_oss/virtual_oss_cmd/virtual_oss_cmd.8  |  103 +
>  51 files changed, 12547 insertions(+), 1 deletion(-)
>

Should this not have been imported using a vendor branch or are we 
intending on maintaining this ourselves without any further imports?


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e**(i*pi)+1=0





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20250929125925.0816B8AF>