Date: Thu, 28 May 2015 21:18:07 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: Johannes Jost Meixner <xmj@freebsd.org>, freebsd-current Current <freebsd-current@freebsd.org>, "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: Need help reducing compilation warnings in CURRENT Message-ID: <20150528191806.GB70327@ivaldir.etoilebsd.net> In-Reply-To: <CAG=rPVcfs4LB36L8ToOFkVad5t=CWb6wSOog=SfWT-8t-7tDwg@mail.gmail.com> References: <CAG=rPVdLjmj8oOeqQQOLr6ShvU=2H3y0j5hg4q8UrB70rj3Xpg@mail.gmail.com> <55670C5A.6080500@FreeBSD.org> <CAG=rPVcfs4LB36L8ToOFkVad5t=CWb6wSOog=SfWT-8t-7tDwg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, May 28, 2015 at 12:09:35PM -0700, Craig Rodrigues wrote: > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner <xmj@freebsd.org> > wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Hi Craig, > > > > I'll gladly help (good excuse to learn C), but looking at those errors > > in general, one thing pops out: > > > > The warnings are almost all in contrib/ areas. Hence, any fix might > > want to probably be submitted to upstream first. > > > > > Sure, if we can push fixes upstream that would be great. > However, we shouldn't let that block us from comitting fixes to FreeBSD. > The advantage of having code in the FreeBSD repo is that we can > change it if we need to, even if the fix isn't yet in the upstream sources. > Contrib code is not made out of stone that can't be modified! > If not upstreamed, there is a good chance it get lost during the next update. So in the special case of warning fixes, I would strongly advice to upstream first!! Best regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlVnae4ACgkQ8kTtMUmk6ExZ2wCdFxVanUstn/epGAk8PsFt4uHI dnUAn2WUKTTX2ObLbG7Kq3ziMVI1wyYD =X+Va -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150528191806.GB70327>