Date: Tue, 11 Dec 2007 18:19:54 GMT From: Sergey Matveychuk <sem@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/118555: [patch] iostat -x: a type like bug in output header Message-ID: <200712111819.lBBIJslc019841@www.freebsd.org> Resent-Message-ID: <200712111820.lBBIK4KC031577@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 118555
>Category: misc
>Synopsis: [patch] iostat -x: a type like bug in output header
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 11 18:20:03 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Sergey Matveychuk
>Release: all
>Organization:
Yandex LLC
>Environment:
>Description:
ioctl -x shows a header that is not compliant with a man page:
extended device statistics
device r/s w/s kr/s kw/s wait svc_t b
The last field should be %b.
I hope it's a type and our developers know how handle with printf(3)
>How-To-Repeat:
run ioctl -x
>Fix:
Patch attached with submission follows:
--- sys/netinet/ip_fw2.c.orig Thu Aug 23 13:19:37 2007
+++ sys/netinet/ip_fw2.c Thu Aug 23 14:12:49 2007
@@ -1591,7 +1591,8 @@
inet_ntoa_r(da, dst);
}
log(LOG_SECURITY | LOG_DEBUG,
- "%s %s:%u -> %s:%u, %s\n",
+ "ipfw: %d %s %s:%u -> %s:%u, %s\n",
+ parent->rule->rulenum,
"drop session",
src, (args->f_id.src_port),
dst, (args->f_id.dst_port),
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712111819.lBBIJslc019841>