Date: Fri, 7 Oct 2011 01:40:48 -0700 From: Craig Rodrigues <rodrigc@crodrigues.org> To: Jaakko Heinonen <jh@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0 Message-ID: <CAG=rPVcOV2H%2Bz04YxLqRRy-W5iNFD7i8fCbMqwZJMwB5%2Bcp1ug@mail.gmail.com> In-Reply-To: <20110930211243.GA2139@jh> References: <CAG=rPVeAPt0_=jNXaHcnB8QCtYuvi5z69MDMFEgyD0HBQT0Mcw@mail.gmail.com> <4E812DB7.3000302@FreeBSD.org> <CAG=rPVcTHiPLFG1%2BdZmi1OWpyZsw=Px=PJT55UFGN_mxt3y%2BJw@mail.gmail.com> <alpine.BSF.2.00.1109262027460.81576@toaster.local> <CAG=rPVeYjqZJuEzVG_kf%2B29bZx%2BZ%2B7du6DsoFou92WDx78B5Dg@mail.gmail.com> <alpine.BSF.2.00.1109262106390.81576@toaster.local> <CAJ-VmokTFaG09=3S8Fw1RwYDJ-Q2OXd0rox6e5AW1DBR4W1AjA@mail.gmail.com> <CAG=rPVdhqhjPEwHGhHBoOYB6rTX=UD2%2B-ehK8-6oT93M5Ec5Tg@mail.gmail.com> <20110928081514.GA5077@jh> <CAG=rPVcLUqs14VfxKffDBWCoBG7u=C5dV45n3ameRXzu5rqHvQ@mail.gmail.com> <20110930211243.GA2139@jh>
next in thread | previous in thread | raw e-mail | index | archive | help
--0015173fe456dc31a304aeb165ee Content-Type: text/plain; charset=ISO-8859-1 On Fri, Sep 30, 2011 at 2:12 PM, Jaakko Heinonen <jh@freebsd.org> wrote: > > Looks mostly OK to me. > > > Why do you use printf() + exit() here and errx() in atacontrol? Is there > reason to not use errx() also here? > > > errx(3) adds a newline character to the output. Thus the latter '\n' is > redundant. > > burncd(8) manual page date should be bumped. > > Thanks. > -- > Jaakko > OK, based on your feedback, I will go with this patch. -- Craig Rodrigues rodrigc@crodrigues.org --0015173fe456dc31a304aeb165ee Content-Type: text/plain; charset=US-ASCII; name="ata_cam_patch.txt" Content-Disposition: attachment; filename="ata_cam_patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gtgxcxek0 SW5kZXg6IHN5cy9kZXYvYXRhL2F0YS1hbGwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvZGV2L2F0YS9h dGEtYWxsLmMJKHJldmlzaW9uIDIyNTM2OCkKKysrIHN5cy9kZXYvYXRhL2F0YS1hbGwuYwkod29y a2luZyBjb3B5KQpAQCAtMTIwLDYgKzEyMCw5IEBACiBUVU5BQkxFX0lOVCgiaHcuYXRhLnNldG1h eCIsICZhdGFfc2V0bWF4KTsKIFNZU0NUTF9JTlQoX2h3X2F0YSwgT0lEX0FVVE8sIHNldG1heCwg Q1RMRkxBR19SRFRVTiwgJmF0YV9zZXRtYXgsIDAsCiAJICAgIkFUQSBkaXNrIHNldCBtYXggbmF0 aXZlIGFkZHJlc3MiKTsKKyNpZmRlZiBBVEFfQ0FNCitGRUFUVVJFKGF0YV9jYW0sICJBVEEgZGV2 aWNlcyBhcmUgYWNjZXNzZWQgdGhyb3VnaCB0aGUgY2FtKDQpIGRyaXZlciIpOworI2VuZGlmCiAK IC8qCiAgKiBuZXdidXMgZGV2aWNlIGludGVyZmFjZSByZWxhdGVkIGZ1bmN0aW9ucwpJbmRleDog dXNyLnNiaW4vYnVybmNkL2J1cm5jZC44Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHVzci5zYmluL2J1cm5jZC9i dXJuY2QuOAkocmV2aXNpb24gMjI1MzY4KQorKysgdXNyLnNiaW4vYnVybmNkL2J1cm5jZC44CSh3 b3JraW5nIGNvcHkpCkBAIC0yNywxMiArMjcsMTkgQEAKIC5cIgogLlwiICRGcmVlQlNEJAogLlwi Ci0uRGQgRGVjZW1iZXIgMjEsIDIwMDkKKy5EZCBPY3RvYmVyIDQsIDIwMTEKIC5EdCBCVVJOQ0Qg OAogLk9zCiAuU2ggTkFNRQogLk5tIGJ1cm5jZAogLk5kIGNvbnRyb2wgdGhlIEFUQVBJIENELVIv UlcgZHJpdmVyCisuUHAKK1RoaXMgdXRpbGl0eSB3YXMKKy5FbSBkZXByZWNhdGVkCitpbgorLkZ4 IDkuMCAuCitTZWUKKy5TeCBOT1RFUyAuCiAuU2ggU1lOT1BTSVMKIC5ObQogLk9wIEZsIGRlRmxt bnBxdHYKQEAgLTIxMSw2ICsyMTgsMTAgQEAKIC5ObQogdXRpbGl0eSBhcHBlYXJlZCBpbgogLkZ4 IDQuMCAuCisuUHAKKy5ObQord2FzIGRlcHJlY2F0ZWQgaW4KKy5GeCA5LjAgLgogLlNoIEFVVEhP UlMKIFRoZQogLk5tCkBAIC0yMjAsMyArMjMxLDE5IEBACiAuQXEgc29zQEZyZWVCU0Qub3JnIC4K IC5TaCBCVUdTCiBQcm9iYWJseSwgcGxlYXNlIHJlcG9ydCB3aGVuIGZvdW5kLgorLlNoIE5PVEVT CitXaGVuCisuQmQgLXJhZ2dlZCAtb2Zmc2V0IGluZGVudAorLkNkICJvcHRpb25zIEFUQV9DQU0i CisuRWQKKy5QcAoraXMgY29tcGlsZWQgaW50byB0aGUga2VybmVsLCB0aGVuCisuWHIgY2RyZWNv cmQgMSAsCithdmFpbGFibGUgaW4gdGhlCisuRngKK1BvcnRzIENvbGxlY3Rpb24gYXMgcGFydCBv ZiB0aGUKKy5QYSBzeXN1dGlscy9jZHJ0b29scworcG9ydCwgbXVzdCBiZSB1c2VkIGluc3RlYWQu CitSZWZlciB0bzoKKy5QcAoraHR0cDovL3d3dy5mcmVlYnNkLm9yZy9kb2MvaGFuZGJvb2svY3Jl YXRpbmctY2RzLmh0bWwjQ0RSRUNPUkQKSW5kZXg6IHVzci5zYmluL2J1cm5jZC9idXJuY2QuYwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSB1c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMJKHJldmlzaW9uIDIyNTM2OCkK KysrIHVzci5zYmluL2J1cm5jZC9idXJuY2QuYwkod29ya2luZyBjb3B5KQpAQCAtODIsNiArODIs MTMgQEAKIAlpbnQgYmxvY2tfc2l6ZSA9IDAsIGJsb2NrX3R5cGUgPSAwLCBjZG9wZW4gPSAwLCBk dmRydyA9IDA7CiAJY29uc3QgY2hhciAqZGV2LCAqZW52X3NwZWVkOwogCisJaWYgKGZlYXR1cmVf cHJlc2VudCgiYXRhX2NhbSIpKSB7CisJCWVycngoMSwgIlxuQVRBX0NBTSBvcHRpb24gaXMgZW5h YmxlZCBpbiBrZXJuZWwuXG4iCisJCSAgICAiSW5zdGFsbCB0aGUgc3lzdXRpbHMvY2RydG9vbHMg cG9ydCBhbmQgdXNlIGNkcmVjb3JkIGluc3RlYWQuXG5cbiIKKwkJICAgICJQbGVhc2UgcmVmZXIg dG86XG4iCisJCSAgICAiaHR0cDovL3d3dy5mcmVlYnNkLm9yZy9kb2MvaGFuZGJvb2svY3JlYXRp bmctY2RzLmh0bWwjQ0RSRUNPUkQiKTsKKwl9CisKIAlpZiAoKGRldiA9IGdldGVudigiQ0RST00i KSkgPT0gTlVMTCkKIAkJZGV2ID0gIi9kZXYvYWNkMCI7CiAKSW5kZXg6IHNiaW4vYXRhY29udHJv bC9hdGFjb250cm9sLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wu YwkocmV2aXNpb24gMjI1MzY4KQorKysgc2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wuYwkod29y a2luZyBjb3B5KQpAQCAtMzc4LDYgKzM3OCwxMSBAQAogewogCWludCBmZCwgbW9kZSwgY2hhbm5l bCwgYXJyYXk7CiAKKwlpZiAoZmVhdHVyZV9wcmVzZW50KCJhdGFfY2FtIikpIHsKKwkJZXJyeCgx LCAiXG5BVEFfQ0FNIG9wdGlvbiBpcyBlbmFibGVkIGluIGtlcm5lbC5cbiIKKwkJICAgICJQbGVh c2UgdXNlIGNhbWNvbnRyb2wgaW5zdGVhZC4iKTsKKwl9CisKIAlpZiAoYXJnYyA8IDIpCiAJCXVz YWdlKCk7CiAKSW5kZXg6IHNiaW4vYXRhY29udHJvbC9hdGFjb250cm9sLjgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gc2Jpbi9hdGFjb250cm9sL2F0YWNvbnRyb2wuOAkocmV2aXNpb24gMjI1MzY4KQorKysgc2Jp bi9hdGFjb250cm9sL2F0YWNvbnRyb2wuOAkod29ya2luZyBjb3B5KQpAQCAtMjUsMTIgKzI1LDE5 IEBACiAuXCIKIC5cIiAkRnJlZUJTRCQKIC5cIgotLkRkIEZlYnJ1YXJ5IDIxLCAyMDA5CisuRGQg T2N0b2JlciA0LCAyMDExCiAuRHQgQVRBQ09OVFJPTCA4CiAuT3MKIC5TaCBOQU1FCiAuTm0gYXRh Y29udHJvbAogLk5kIEFUQSBkZXZpY2UgZHJpdmVyIGNvbnRyb2wgcHJvZ3JhbQorLlBwCitUaGlz IHV0aWxpdHkgd2FzCisuRW0gZGVwcmVjYXRlZAoraW4KKy5GeCA5LjAgLgorU2VlCisuU3ggTk9U RVMgLgogLlNoIFNZTk9QU0lTCiAuTm0KIC5BcSBBciBjb21tYW5kCkBAIC0zNjEsMTEgKzM2OCwx NyBAQAogdXAgYWxsIHRoZSB0aW1lLgogLlNoIFNFRSBBTFNPCiAuWHIgYXRhIDQKKy5YciBjYW0g NAorLlhyIGNhbWNvbnRyb2wgOAogLlNoIEhJU1RPUlkKIFRoZQogLk5tCiB1dGlsaXR5IGZpcnN0 IGFwcGVhcmVkIGluCiAuRnggNC42IC4KKy5QcAorLk5tCit3YXMgZGVwcmVjYXRlZCBpbgorLkZ4 IDkuMCAuCiAuU2ggQVVUSE9SUwogLkFuIC1ub3NwbGl0CiBUaGUKQEAgLTM3NywzICszOTAsMTYg QEAKIFRoaXMgbWFudWFsIHBhZ2Ugd2FzIHdyaXR0ZW4gYnkKIC5BbiBTXCgvb3JlbiBTY2htaWR0 CiAuQXEgc29zQEZyZWVCU0Qub3JnIC4KKy5TaCBOT1RFUworVGhlCisuTm0KK3V0aWxpdHkgd2Fz IGRlcHJlY2F0ZWQgaW4KKy5GeCA5LjAgLgorV2hlbgorLkJkIC1yYWdnZWQgLW9mZnNldCBpbmRl bnQKKy5DZCAib3B0aW9ucyBBVEFfQ0FNIgorLkVkCisuUHAKK2lzIGNvbXBpbGVkIGludG8gdGhl IGtlcm5lbCwgdGhlbgorLlhyIGNhbWNvbnRyb2wgOAorbXVzdCBiZSB1c2VkIGluc3RlYWQuCg== --0015173fe456dc31a304aeb165ee--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVcOV2H%2Bz04YxLqRRy-W5iNFD7i8fCbMqwZJMwB5%2Bcp1ug>