Date: Wed, 30 May 2018 12:39:32 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334361 - head/usr.sbin/pmc Message-ID: <F3B7BA9C-DE23-429F-B1C7-4F118812C224@FreeBSD.org> In-Reply-To: <20180530092459.GP3789@kib.kiev.ua> References: <201805300006.w4U06HK3055256@repo.freebsd.org> <20180530092459.GP3789@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 30 May 2018, at 11:24, Konstantin Belousov <kostikbel@gmail.com> wrote: > > On Wed, May 30, 2018 at 12:06:17AM +0000, Matt Macy wrote: >> Author: mmacy >> Date: Wed May 30 00:06:17 2018 >> New Revision: 334361 >> URL: https://svnweb.freebsd.org/changeset/base/334361 >> >> Log: >> pmc: don't break build with format issues >> >> Modified: >> head/usr.sbin/pmc/Makefile >> >> Modified: head/usr.sbin/pmc/Makefile >> ============================================================================== >> --- head/usr.sbin/pmc/Makefile Tue May 29 23:08:33 2018 (r334360) >> +++ head/usr.sbin/pmc/Makefile Wed May 30 00:06:17 2018 (r334361) >> @@ -9,4 +9,5 @@ LIBADD= kvm pmc m ncursesw pmcstat elf >> >> SRCS= pmc.c pmc_util.c cmd_pmc_stat.c >> >> +CWARNFLAGS.cmd_pmc_stat.c= -Wno-format >> .include <bsd.prog.mk> > So this builds knownly broken binary instead of stopping. > > If I understand your troubles right, the usual solution for them is > printf("%jx", (uintmax_t)trouble); > used in many places around the kernel, less so in userspace. Yes, or include <inttypes.h> and use the PRIu64 macro, even though Bruce hates it. :) -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWw5/ZAAKCRCwXqMKLiCW o64dAJ9GAEJ/8CtJOtWAZ6g/961XkkbscwCg/ZT6CN4vKovKqV+cOTL3/D69sRg= =dngA -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F3B7BA9C-DE23-429F-B1C7-4F118812C224>